Log when Magento is in maintenance mode #16840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's not play guessing games why we're getting a 500 errors...
|
|
|
Hi @Ethan3600. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Please sign the CLA. |
|
Signed |
Ethan3600
commented
Jul 19, 2018
| @@ -259,7 +259,7 @@ public function run(AppInterface $application) | |||
| \Magento\Framework\Profiler::stop('magento'); | |||
| } catch (\Exception $e) { | |||
| \Magento\Framework\Profiler::stop('magento'); | |||
| $this->objectManager->get(LoggerInterface::class)->error($e); | |||
| $this->objectManager->get(LoggerInterface::class)->error($e->getMessage()); | |||
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 23, 2018
|
Hi @Ethan3600. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logging when Magento is in maintenance mode.
Not sure if I'm the only one that fell for this, but I've (embarrassingly) spent hours trying figuring out why Magento was throwing a 500 error; only to find that it was just in maintenance mode...
Logging this will save developers some time, and eliminate some of the guess work involved with troubleshooting obscure errors.
This is usually applicable when a deployment goes a little haywire.
As a "side-affect" we'd also be logging errors coming from the launch process, which I don't think is that much of an issue.
Manual testing scenarios
tail -f var/log/system.logContribution checklist