-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide cookie notice instead of reloading site #16890
hide cookie notice instead of reloading site #16890
Conversation
Hi @torhoehn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @torhoehn. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Hello @torhoehn |
Hi @nuzil. I did review it again. For me it looks like that the pageview will be recognized and it doesn't matter if the cookie notice will be closed by the user or not. So it's just a hint without any functionality in the background. |
Description
Instead of reloading the whole site when a use accepts the cookie notice, it should be accpetable to close the cookie notice only.
Manual testing scenarios
Contribution checklist