Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Avoid undefined index warning when using uppercase reserved word #17016

Conversation

FreekVandeursen
Copy link

Original Pull Request

#16785
ReservedWordsSniff will trigger an undefined index error if a reserved word is used in uppercase.

Manual testing scenarios

  1. Create a class containing a reserved word, with at least 1 uppercase character (e.g. Bool)
  2. execute phpcs codesniffer with dev/tests/static/framework/Magento/ruleset.xml ruleset

Expected result

Code sniffer error "Cannot use "Bool" in namespace as it is reserved since PHP 7"

Actual result

Code sniffer error "An error occurred during processing; checking has been aborted. The error message was: Undefined index: Bool"

@magento-engcom-team
Copy link
Contributor

Hi @FreekVandeursen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @FreekVandeursen. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants