BUG FIX - Uncaught exception when accessing admin with none existent use... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user. Summary: When attempting to login to the Magento admin. If the user does not exist the resource method loadByUsername returns false. This result is passed to setData that will then throw an exception. Fix: Added a test to confirm $user is returned before calling setData. This allows the execution to correctly fail through to the standard exception handler and display an appropriately secure exception message.
| @@ -384,7 +384,11 @@ public function reload() | |||
| */ | |||
| public function loadByUsername($username) | |||
| { | |||
| $this->setData($this->getResource()->loadByUsername($username)); | |||
There was a problem hiding this comment.
Would you like to practice implementing an integration test for this method?
Supposedly dev/tests/integration/testsuite/Mage/Admin/Model/UserTest.php -- it doesn't exist yet. But implementing just loadByUsernameTest() would be enough.
I recommend using @magentoDataFixture to create a test admin account fixture. The fixture will be reverted automatically after test execution.
added 2 commits
January 20, 2012 23:18
Response to @antonmakarenko following comments on the pull request Summary: Created new testcase for Mage_Admin_Model_User Added fixture file to create an Admin user for testing.
|
I have now added the requested tests for this method and included fixtures. |
|
Thank you, Alistair. The changes were incorporated into Magento 2 and pushed to Github. Closing this pull request. |
Closed
Closed
5 tasks
5 tasks
5 tasks
ghost
mentioned this pull request
5 tasks
6 tasks
5 tasks
5 tasks
5 tasks
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jun 5, 2024
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jun 5, 2024
5 tasks
5 tasks
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jul 4, 2024
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 6, 2024
…an 0. Can't upload specific image
4 tasks
in-session
added a commit
to in-session/magento2
that referenced
this pull request
Aug 13, 2024
[Exception] Deprecated Functionality: explode(): Passing null to parameter magento#2 ($string) of type string is deprecated in /var/www/html/lib/internal/Magento/Framewo rk/Validator/EmailAddress.php on line 68
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...r.
Summary:
When attempting to login to the Magento admin. If the user does not exist the resource method loadByUsername returns false. This result is passed to setData that will then throw an exception.
Fix:
Added a test to confirm $user is returned before calling setData. This allows the execution to correctly fail through to the standard exception handler and display an appropriately secure exception message.