Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue fixed #20259 Store switcher not sliding up and down, only dropd… #20260

Merged
merged 3 commits into from
Jan 23, 2019
Merged

issue fixed #20259 Store switcher not sliding up and down, only dropd… #20260

merged 3 commits into from
Jan 23, 2019

Conversation

cedarvinda
Copy link
Member

issue fixed #20259 Store switcher not sliding up and down, only dropdown arrow working

Description (*)

Store switcher not sliding up and down, only dropdown arrow working

Step 1: Go to frontend in mobile device
Step 2: click on toggle in left top corner
Step 3: Go to setting tab and see store switcher and clcik on label (Ref screenshot)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@cedarvinda
issue fixed #20259 Store switcher not sliding up and down, only dropd…
8bc0309 
…own arrow working

issue fixed #20259 Store switcher not sliding up and down, only dropdown arrow working
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jan 14, 2019
VladimirZaets
VladimirZaets reviewed Jan 14, 2019
View reviewed changes
app/design/frontend/Magento/blank/web/css/source/_navigation.less Outdated
}

.switcher-options{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cedarvinda. Thanks for collaboration. Please fix code indents after class declaration.

VladimirZaets
VladimirZaets reviewed Jan 14, 2019
View reviewed changes
app/design/frontend/Magento/blank/web/css/source/_navigation.less
@@ -135,8 +135,15 @@
.switcher-dropdown {
.lib-list-reset-styles();
padding: @indent__s 0;
display: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that we should manually hide dropdown?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should for mobile because that will open if user will click in hi label.

@miguelbalparda miguelbalparda removed their request for review January 14, 2019 16:06
@cedarvinda
_navigation.less updated
905368c 
_navigation.less updated
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3869 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Jan 23, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit ec33182 into magento:2.3-develop Jan 23, 2019
@ghost
Copy link

ghost commented Jan 23, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2019
@sidolov
ENGCOM-3869: issue fixed #20259 Store switcher not sliding up and dow…
b09ff50 
…n, only dropd… #20260
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@irajneeshgupta irajneeshgupta mentioned this pull request Jan 23, 2019
Merged
4 tasks
@amol2jcommerce amol2jcommerce mentioned this pull request Jan 23, 2019
Merged
4 tasks
@shikhamis11 shikhamis11 mentioned this pull request Jan 24, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Award: bug fix Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.

Store switcher not sliding up and down, only dropdown arrow working
4 participants
@cedarvinda @magento-engcom-team @VladimirZaets @p-bystritsky