Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed-View-and-Edit-Cart-link-not-aligned-in-middle #20388

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 18, 2019

Description (*)

Original PR: #20383

Fixed Issues (if relevant)

  1. View and Edit Cart link not aligned in middle because bellow the link a blank div (class="minicart-widgets") existing has 15px margin top, this div (class="minicart-widgets" ) should be display none or should not come if has no content, should only display if has content #20382: View and Edit Cart link not aligned in middle
  2. Magento 2.2

Manual testing scenarios (*)

  1. Open frontend
  2. Add any product in cart and go to minicart and see View and Edit Cart Link
  3. You will see extra space bellow the link

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@irajneeshgupta
Copy link
Member

Dublicate PR ref -> #20383

@ghost
Copy link

ghost commented Jan 18, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@amol2jcommerce
Copy link
Contributor Author

amol2jcommerce commented Jan 18, 2019

Hi @irajneeshgupta

PR ref -> #20383 is for Magento 2.3. PR ref-> #20388 is 2.2

@rogyar rogyar changed the title Fixed-View-and-Edit-Cart-link-not-aligned-in-middle [Backport] Fixed-View-and-Edit-Cart-link-not-aligned-in-middle Jan 18, 2019
@rogyar rogyar self-assigned this Jan 18, 2019
@irajneeshgupta
Copy link
Member

irajneeshgupta commented Jan 21, 2019

@rogyar The port is not cherry picked from my original commits in PR #20383 and is not up to date.
@amol2jcommerce Hence, I suggest not creating port until the original 2.3-develop PR is verified or merged.

@amol2jcommerce
Copy link
Contributor Author

Hi @rogyar this branch is now up to date as per suggestion of @Karlasa in #20383

@ghost
Copy link

ghost commented Feb 11, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants