Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixing the styling issue on customizable options #20821

Merged

Conversation

eduard13
Copy link
Contributor

Description (*)

Original PR #20498

This PR fixes the view of customizable options style issue

Fixed Issues (if relevant)

  1. Product customizable options issue #20497: Product customizable options issue
  2. ...

Manual testing scenarios (*)

  1. Open the product page (new or existing one) in Admin Panel
  2. Add several new Customizable Options

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Design/Frontend Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 30, 2019
@eduard13 eduard13 changed the title Fixing the styling issue on customizable options [Backport] Fixing the styling issue on customizable options Jan 30, 2019
@dmytro-ch dmytro-ch self-requested a review February 11, 2019 09:41
@dmytro-ch dmytro-ch self-assigned this Feb 11, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-20821.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch removed the request for review from rogyar February 11, 2019 11:00
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4204 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Cleanup Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants