Fix > Exception #0 (BadMethodCallException): Missing required argument $msrpPriceCalculators of Magento\Msrp\Pricing\MsrpPriceCalculator.

[lfluvisotto]

Description (*)

Fix > Exception #0 (BadMethodCallException): Missing required argument $msrpPriceCalculators of Magento\Msrp\Pricing\MsrpPriceCalculator.

Fixed Issues (if relevant)

#22190: Exception (BadMethodCallException): Missing required argument $msrpPriceCalculators of Magento\Msrp\Pricing\MsrpPriceCalculator.

Manual testing scenarios (*)

1. Modules Magento_MsrpConfigurableProduct or Magento_MsrpGroupedProduct must be enable for module Magento_Msrp works properly

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Such dependency is incorrect. Those modules must depend on Msrp and not vise versa.

[lfluvisotto]

@orlangur

In > app/code/Magento/MsrpConfigurableProduct/etc/module.xml there is the dependency / sequence with module Magento_Msrp, so far, so good.

In > app/code/Magento/MsrpGroupedProduct/etc/module.xml there is the dependency / sequence with module Magento_Msrp, so far, so good.

But if you disable these modules MsrpConfigurableProduct and MsrpGroupedProduct, the module Magento_Msrp is dependent of MsrpConfigurableProduct or MsrpGroupedProduct.

The file app/code/Magento/Msrp/Pricing/MsrpPriceCalculator.php > public function __construct(array $msrpPriceCalculators) > it's supposed to receive as an argument MsrpConfigurableProduct or MsrpGroupedProduct

With both modules MsrpConfigurableProduct and MsrpGroupedProduct disabled the crash happens.

These are declared in:

app/code/Magento/MsrpConfigurableProduct/etc/di.xml

app/code/Magento/MsrpGroupedProduct/etc/di.xml

The way Magento_Msrp was built/developed is dependent of MsrpConfigurableProduct and MsrpGroupedProduct

Have a look at this commit:

db2e9f0

MsrpConfigurableProduct provides type and resolver information for the Msrp module from the ConfigurableProduct module.

MsrpGroupedProduct provides type and resolver information for the Msrp module from the GroupedProduct module.

Msrp is attached to MsrpConfigurableProduct and MsrpGroupedProduct

[lfluvisotto]

@davidverholen @orlangur

I've checked again my solution but it's wrong it's generating > Circular sequence reference

Disregard my pull request, a refactoring is necessary in Magento_Msrp, possibly in app/code/Magento/Msrp/Pricing/MsrpPriceCalculator.php

[m2-assistant]

Hi @lfluvisotto, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[lfluvisotto]

@davidverholen @orlangur

Have a look at my new pull request #22197

I hope it's ok now.