Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14958 - remove sales sequence data on store view delete #22296

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Apr 12, 2019

In this PR I tried to fix #18466 after it was probably abaddoned.

Description (*)

Fixed Issues (if relevant)

  1. sale_sequence_* records are not removed on store view deletion #14958: sale_sequence_* records are not removed on store view deletion

Manual testing scenarios (*)

  1. Delete existing store view
  2. Check sale_sequence_meta and sales_sequence_profile tables - those shouldn't contain any data related to deleted store view.
  3. All sequence tables for deleted store view should not exist.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 12, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch self-requested a review April 13, 2019 08:13
@dmytro-ch dmytro-ch self-assigned this Apr 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4781 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 18, 2019
@AlexWorking AlexWorking self-assigned this Apr 18, 2019
@ghost ghost unassigned AlexWorking Apr 18, 2019
@ghost
Copy link

ghost commented Apr 18, 2019

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky force-pushed the feature/fix_14958_sales_sequence_removal branch from 5ff602b to 1219193 Compare January 6, 2020 12:29
@Bartlomiejsz Bartlomiejsz added Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Jan 6, 2020
@p-bystritsky p-bystritsky force-pushed the feature/fix_14958_sales_sequence_removal branch from 1219193 to 086b919 Compare January 8, 2020 09:43
@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@engcom-Golf engcom-Golf force-pushed the feature/fix_14958_sales_sequence_removal branch from aed5d9e to 449e026 Compare February 17, 2020 12:18
@engcom-Golf
Copy link
Contributor

@magento run all tests

@Nazar65 Nazar65 force-pushed the feature/fix_14958_sales_sequence_removal branch 3 times, most recently from 68ed2be to f894321 Compare February 17, 2020 19:37
@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/fix_14958_sales_sequence_removal branch February 21, 2020 23:44
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: SalesSequence Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.