Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Totals Sort Order fields can't be empty and should be a number #22411

Merged
merged 1 commit into from
Apr 27, 2019
Merged

Conversation

barbanet
Copy link
Member

If, for some reason, a backend user deletes the content of one or all Configuration -> Sales -> Sales -> Checkout Totals Sort Order fields, the checkout won't work and you won't see an error and no exceptions seems to be logged.

Description (*)

Now, field Subtotal, Discount, Shipping, Tax, Fixed Product Tax and Grand Total; inside Configuration -> Sales -> Sales -> Checkout Totals Sort Order, are required and can't be empty anymore.

Manual testing scenarios (*)

  1. Go to Configuration -> Sales -> Sales -> Checkout Totals Sort Order
  2. Remove all the values and save the configuration

2019-04-18-03

  1. Go the the storefront, add a product to the cart and try to access to the checkout. You'll see this page:

2019-04-18-04

  1. If you apply the validation from this PR you won't be able to save those fields with empty values.

2019-04-18-07

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2019

Hi @barbanet. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 18, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-4798 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost
Copy link

ghost commented Apr 23, 2019

@Nazar65 unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@magento-engcom-team magento-engcom-team merged commit d4eeb44 into magento:2.3-develop Apr 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2019

Hi @barbanet, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants