Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Corrected the translation for comment tag #22447

Conversation

yogeshsuhagiya
Copy link
Member

Original Pull Request

#21023

Description (*)

Corrected the translation for <comment> tag and added translation key
Goto: STORES > Configuration > Payment Methods > RECOMMENDED SOLUTIONS: > OTHER PAYPAL PAYMENT SOLUTIONS: > Payflow Pro > Required PayPal Settings > Payflow Pro and Express Checkout. > Enable PayPal Credit

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2019

Hi @yogeshsuhagiya. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yogeshsuhagiya please adopt corresponding tests to your changes.

@ghost ghost assigned orlangur Apr 22, 2019
@yogeshsuhagiya
Copy link
Member Author

Hi @orlangur, I'm not getting your point, can you please let me know which tests I've to adopt?

@orlangur
Copy link
Contributor

@yogeshsuhagiya check Travis CI builds which are currently failing.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@Nazar65
Copy link
Member

Nazar65 commented May 3, 2019

ping @orlangur to approve.

@Nazar65 Nazar65 requested a review from orlangur May 6, 2019 06:28
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5014 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit b8b2458 into magento:2.2-develop May 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 7, 2019

Hi @yogeshsuhagiya, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants