Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Shortening currency list in Configuration->General (replace PR #20397) #22551

Merged
merged 1 commit into from
May 3, 2019
Merged

[Backport] Shortening currency list in Configuration->General (replace PR #20397) #22551

merged 1 commit into from
May 3, 2019

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#22230

Description (*)

in Store->Configuration->General->Currency setup will be shown only those currencies selected in
Installed currencies list (Configuration->Advanced->System)

This filters the list of allowed currencies to show only selected ones

This PR replaces closed one #19946

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios (*)

  1. The list of currencies will look like in screenshot
    screenshot 2019-01-18 14 26 30

  2. These changes can be applied to 2.2.x as well

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch self-assigned this Apr 30, 2019
@dmytro-ch dmytro-ch self-requested a review April 30, 2019 10:18
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-22551.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4857 has been created to process this Pull Request

@soleksii soleksii self-assigned this Apr 30, 2019
@nmalevanec nmalevanec self-assigned this May 2, 2019
@soleksii
Copy link

soleksii commented May 2, 2019

✔️ QA Passed

Before:

before

After:

after

@magento-engcom-team magento-engcom-team merged commit f54c202 into magento:2.2-develop May 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 3, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 3, 2019
@sidolov
ENGCOM-4857: [Backport] Shortening currency list in Configuration->Ge…
b7db604 
…neral (replace PR #20397) #22551
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@nmalevanec nmalevanec

@dmytro-ch dmytro-ch

@soleksii soleksii

Labels
Component: Config Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
6 participants
@amol2jcommerce @dmytro-ch @magento-engcom-team @soleksii @nmalevanec @melaxon