Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Non existing file, when adding image to gallery with move option. Fix for #21978 #22579

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#22020

Description (*)

  1. Fix for throwing error "File not exist" when adding image to product via addImageToMediaGallery method with $move.

Fixed Issues (if relevant)

  1. Adding product image: File doesn't exist #21978: Adding product image: File doesn't exist Adding product image: File doesn't exist #21978

Manual testing scenarios (*)

  1. Add image via above method programatically.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 2, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5016 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 3, 2019
@Nazar65 Nazar65 self-assigned this May 3, 2019
@soleksii
Copy link

soleksii commented May 3, 2019

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented May 6, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 6, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone May 6, 2019
@mregula
Copy link

mregula commented Jul 23, 2019

Magento 2.3.2 still has this issue :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants