[Backport] Alignment Issue While Editing Order Data containing Downlodable Products with "Links can be purchased separately" enabled in Admin Section

[deepakk-webkul]

Original Pull Request

#22298
Alignment Issue While Editing Order Data containing Downlodable Products with "Links can be purchased separately" enabled in Admin Section

Description (*)

Magento 2.3.x
Magento 2.2.x

Fixed Issues (if relevant)

1. Alignment Issue While Editing Order Data containing Downlodable Products in Admin Section #20917: Alignment Issue While Editing Order Data containing Downlodable Products in Admin Section

Manual testing scenarios (*)

1. Login into admin panel
2. go to Order grid section from Sales > Orders
3. Reorder any order containing downladable product with "Links can be purchased separately" enabled.
4. now click on configure button : https://prnt.sc/navb8m
5. A modal will display an alignment issue : https://prnt.sc/navble

Actual result (*)

https://prnt.sc/navble

Expected result (*)

https://prnt.sc/navc9o

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @webkul-deepakkumar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @ronak2ram, thank you for the review.
ENGCOM-5017 has been created to process this Pull Request

[magento-engcom-team]

@webkul-deepakkumar thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[orlangur]

@dmytro-ch @sivaschenko do we allow such kind of cleanup to be backported?

[dmytro-ch]

As a matter of fact, the backport should be rejected if the original pull request is marked as a cleanup.
We've got many similar PRs for 2.2 release line previously. Those PRs have been also closed despite the necessity of the provided fixes.

[orlangur]

@dmytro-ch I personally would allow to backport anything which produces visually recognizable result as otherwise it is hard to determine what is an "important fix". But we should be consistent on this and have clear rules for any situation.

[soleksii]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @webkul-deepakkumar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.