Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Magento backend catalog cost without currency symbol" as Cost… #22739

Conversation

orlangur
Copy link
Contributor

@orlangur orlangur commented May 5, 2019

… column must not be added to grid by default

This reverts commit 85beeec.

Description (*)

Manual testing scenarios (*)

  1. Open product grid and make sure Cost column is absent by default
  2. Magento backend catalog "Cost" without currency symbol #20906 should be still reproducible

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… column must not be added to grid by default

This reverts commit 85beeec.
@m2-assistant
Copy link

m2-assistant bot commented May 5, 2019

Hi @orlangur. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor Author

orlangur commented May 5, 2019

@dmytro-ch please review this PR as you was the first to notice invalid changes in #21911 (review)

@dmytro-ch dmytro-ch self-requested a review May 6, 2019 06:00
@dmytro-ch dmytro-ch self-assigned this May 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5067 has been created to process this Pull Request

@dmytro-ch
Copy link
Contributor

Nice catch @orlangur!
I totally agree that the issue with currency symbol should be fixed in a proper way.
It's not possible to make all the price attributes visible in the product grid by default in order to fix the issue.
Thank you.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @orlangur, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants