Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#14971: Improper Handling of Pagination SEO #23298

Closed

Conversation

benathomeofchampions
Copy link

This removes the p= query string parameter in pagination for the first page, when navigating back to page 1, to avoid duplicate content SEO issues.

Description (*)

First page pagination links will still include the pagination query string (for example p=1) which causes a duplicate content SEO issue.

Fixed Issues (if relevant)

  1. Improper Handling of Pagination SEO #14971: Improper Handling of Pagination SEO

Manual testing scenarios (*)

  1. Visit a category with more than 1 page
  2. Use pagination to go to page 2
  3. Return to page 1 via pagination and verify that the pagination query string parameter is not present in the URL

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

This removes the p= query string parameter in pagination for the first page, when navigating back to page 1, to avoid duplicate content SEO issues.
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2019

Hi @benathomeofchampions. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 18, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5625 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

Hi @benathomeofchampions

During testing we faced the issue

Problem: Value ?p=1 appended when we add an additional parameter

Steps to reproduce:

  1. Visit a category with more than 1 page;
  2. Select list mode 1566198420496
  3. Use pagination to go to page 2;
  4. Return to page 1 via pagination;

Actual Result:
after

@benathomeofchampions Could you take a look, please?

Thanks!

@sidolov
Copy link
Contributor

sidolov commented Sep 3, 2019

@benathomeofchampions , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Sep 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 3, 2019

Hi @benathomeofchampions, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants