Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc block for $queueIterator Magento\Framework\MessageQueue\Topology\Config #24976

Merged

Conversation

UncleTioma
Copy link
Contributor

Description (*)

There is an incorrect @var reference in the doc block of the class member variable $queueIterator in class
\Magento\Framework\MessageQueue\Topology\Config

Fixed Issues (if relevant)

  1. Incorrect @var reference in docBlock of a class member variable #24971: Incorrect @var reference in docBlock of a class member variable

Manual testing scenarios (*)

  1. Check the doc block of this class member variable \Magento\Framework\MessageQueue\Topology\Config::$queueIterator in file vendor/magento/framework-message-queue/Topology/Config.php

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 11, 2019

Hi @UncleTioma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:18
@lenaorobei
Copy link
Contributor

@magento run Integration Tests

@lenaorobei lenaorobei added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6902 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Feb 17, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 21, 2020
@magento-engcom-team magento-engcom-team merged commit 8aaa161 into magento:2.4-develop Feb 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @UncleTioma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: MessageQueue Partner: Elogic partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4 Squashtoberfest 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants