Error in vendor/magento/module-shipping/Model/Config/Source/Allmethod…

[mrodespin]

Description (*)

If a module has a selectable configuration using the source app/code/Magento/Shipping/Model/Config/Source/Allmethods.php and one shipping method has the allowed shipping methods to null admin page won't render properly (Blank page)

Fixed Issues (if relevant)

1. Error in vendor/magento/module-shipping/Model/Config/Source/Allmethods.php - public function toOptionArray #13136: Error in vendor/magento/module-shipping/Model/Config/Source/Allmethods.php - public function toOptionArray

Manual testing scenarios (*)

1. Made a composer require of the module described on the task (magmodules/magento2-channable)
2. Edited the configuration value carriers/usps/allowed_methods to NULL on core_config_data.
3. Open the admin configuration of channable module.
4. Checked that the configuration page throws and error and no content is rendered.
5. Reviewed how usps module returns the allowed methods on this file app/code/Magento/Usps/Model/Carrier.php
6. Modified the file app/code/Magento/Shipping/Model/Config/Source/Allmethods.php for control this error with all allowedmethods functions.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mrodespin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[kalpmehta]

@mrodespin Can you please cover the changes with tests? Thanks

[magento-engcom-team]

Hi @kalpmehta, thank you for the review.
ENGCOM-6436 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @mrodespin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.