Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14971 Improper Handling of Pagination SEO #25337

Merged
merged 5 commits into from
Jan 9, 2020
Merged

#14971 Improper Handling of Pagination SEO #25337

merged 5 commits into from
Jan 9, 2020

Conversation

chickenland
Copy link
Contributor

This PR removes the p= query string parameter when navigating to the first page - to avoid duplicate content SEO issues.

Description (*)

First page pagination link include the pagination query string (for example p=1) when on a later page - which causes a duplicate content SEO issue.

Fixed Issues (if relevant) (*)

#14971: Improper Handling of Pagination SEO

Manual testing scenarios (*)

  • Visit a category with more than 1 page
  • Use pagination to go to page 2
  • Return to page 1 via pagination and verify that the pagination query string parameter is not present in the URL

Manual testing scenarios (*)

  • Visit a category with more than 1 page
  • Use pagination to go to page 2
  • Add a filter
  • Return to page 1 via pagination and verify that the pagination query string parameter is not present in the URL, but the filter is

@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2019

Hi @chickenland. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@slavvka
Copy link
Member

slavvka commented Oct 31, 2019

@magento run all tests

@chickenland
Copy link
Contributor Author

chickenland commented Oct 31, 2019

Looks like the code test is failing on the file I've altered, but not in a function I've changed code.

Shall I fix as part of this?

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17
@krzksz
Copy link
Contributor

krzksz commented Dec 8, 2019

Hey @chickenland, yes please fix the issues if possible.

@ghost ghost assigned krzksz Dec 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6455 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@krzksz krzksz added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Dec 12, 2019
@engcom-Alfa engcom-Alfa self-assigned this Dec 16, 2019
@engcom-Alfa
Copy link
Contributor

Hi @chickenland .
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by auto test.
Thanks!

@engcom-Golf
Copy link
Contributor

I will take care of test coverage

@engcom-Golf engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 6, 2020
@engcom-Golf
Copy link
Contributor

Hi @krzksz all changes covered by unit test could you please review ?

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6455 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @chickenland, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants