Magento#25669: fixed issue "health_check.php fails if any database cache engine configured" #25722

andrewbess · 2019-11-24T19:07:13Z

Description (*)

This PR fixes the issue /issues/25669: health_check.php fails if any database cache engine configured.

Fixed Issues (if relevant)

health_check.php fails if any database cache engine configured #25669: health_check.php fails if any database cache engine configured

Manual testing scenarios (*)

Create custom cache engine like it described in devdocs
Configure any cache to database in env.php (for example look at Configuration examples)
Run ./bin/magento setup:di:compile and wait finishing
Run health_check.php

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

@return

…nfigured - fixed wrong "@return description" of the remove method in class Magento\Framework\Cache\Backend\Database - fixed wrong returned type of the method "unlock" in class Magento\Framework\Lock\Backend\Cache - fixed health_check to create instances into block "check cache storage availability"

m2-assistant · 2019-11-24T19:07:16Z

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

…nfigured - fixed PHPDocs according to requirements static tests for CE

andrewbess · 2019-11-25T13:17:13Z

https://prnt.sc/q1rujl
It was removing wrong commit where I pulled changes from 2.3-develop into issue-25669.

pub/health_check.php

rogyar · 2019-12-04T13:15:43Z

lib/internal/Magento/Framework/Lock/Backend/Cache.php

@@ -45,7 +45,7 @@ public function lock(string $name, int $timeout = -1): bool
     */
    public function unlock(string $name): bool
    {
-        return $this->cache->remove($this->getIdentifier($name));
+        return (bool)$this->cache->remove($this->getIdentifier($name));


Could I kindly ask you to cover this part using a simple unit test? Just mock a behavior that caused an error previously for $this->cache->remove($this->getIdentifier($name)) and make sure that there's no error after the proposed change.

Thank you!

Hello @rogyar
Tests have already created.
Thank you @engcom-Echo

… issue-25669

engcom-Echo · 2020-02-04T13:28:49Z

I will take care of test coverage.

magento-engcom-team · 2020-02-09T15:40:44Z

Hi @rogyar, thank you for the review.
ENGCOM-6834 has been created to process this Pull Request

engcom-Echo · 2020-03-13T13:30:37Z

✔️ QA passed

…ase cache engine configured" #25722

m2-assistant · 2020-03-15T20:37:46Z

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

andrewbess requested a review from kokoc as a code owner November 24, 2019 19:07

magento-engcom-team added Component: Cache Component: Lock Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 24, 2019

magento#25669: health_check.php fails if any database cache engine co…

3905038

…nfigured - fixed PHPDocs according to requirements static tests for CE

andrewbess force-pushed the issue-25669 branch from 4d4e755 to 3905038 Compare November 25, 2019 13:13

rogyar self-assigned this Dec 4, 2019

rogyar requested changes Dec 4, 2019

View reviewed changes

ghost added the Progress: needs update label Dec 4, 2019

rogyar added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Progress: needs update and removed Progress: needs update labels Dec 4, 2019

sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:12

sidolov added Release Line: 2.4 and removed Release Line: 2.3 labels Dec 5, 2019

engcom-Echo added 2 commits February 4, 2020 14:45

Merge branch '2.4-develop' of http://github.com/magento/magento2 into…

e59ee3a

… issue-25669

Covered unit test

6633cc2

engcom-Echo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Feb 4, 2020

engcom-Echo requested a review from rogyar February 4, 2020 13:29

rogyar added the Award: bug fix label Feb 9, 2020

rogyar approved these changes Feb 9, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Feb 9, 2020

ghost added Progress: testing in progress Progress: ready for testing and removed Progress: ready for testing Progress: testing in progress labels Feb 14, 2020

dmytro-ch added the Award: category of expertise label Feb 20, 2020

engcom-Echo self-assigned this Mar 13, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 13, 2020

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Mar 13, 2020

magento-engcom-team mentioned this pull request Mar 15, 2020

health_check.php fails if any database cache engine configured #25669

Closed

magento-engcom-team pushed a commit that referenced this pull request Mar 15, 2020

ENGCOM-6834: #25669: fixed issue "health_check.php fails if any datab…

5c39911

…ase cache engine configured" #25722

magento-engcom-team merged commit 2d3ad56 into magento:2.4-develop Mar 15, 2020

andrewbess deleted the issue-25669 branch October 28, 2020 09:58

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Magento#25669: fixed issue "health_check.php fails if any database cache engine configured" #25722

Magento#25669: fixed issue "health_check.php fails if any database cache engine configured" #25722

andrewbess commented Nov 24, 2019

m2-assistant bot commented Nov 24, 2019

andrewbess commented Nov 25, 2019

rogyar Dec 4, 2019

andrewbess Feb 9, 2020

engcom-Echo commented Feb 4, 2020

magento-engcom-team commented Feb 9, 2020

engcom-Echo commented Mar 13, 2020

m2-assistant bot commented Mar 15, 2020

Magento#25669: fixed issue "health_check.php fails if any database cache engine configured" #25722

Magento#25669: fixed issue "health_check.php fails if any database cache engine configured" #25722

Conversation

andrewbess commented Nov 24, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Nov 24, 2019

andrewbess commented Nov 25, 2019

rogyar Dec 4, 2019

Choose a reason for hiding this comment

andrewbess Feb 9, 2020

Choose a reason for hiding this comment

engcom-Echo commented Feb 4, 2020

magento-engcom-team commented Feb 9, 2020

engcom-Echo commented Mar 13, 2020

m2-assistant bot commented Mar 15, 2020