Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXES] #25674: Elasticsearch version selections in admin are overly … #25838

Merged
merged 2 commits into from
Dec 29, 2019

Conversation

mautz-et-tong
Copy link
Contributor

…broad.

Description (*)

This removes the X.0+ notation and replaces it with X.x notation

Fixed Issues (if relevant)

  1. Elasticsearch version selections in admin are overly broad #25674: Elasticsearch version selections in admin are overly broad

Manual testing scenarios (*)

  1. Login to Admin
  2. Go to Stores -> Configuration -> Catalog -> Catalog
  3. Open Catalog Search Configuration
  4. Check the entries in the dropdown "Search Engine"

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…overly broad.

This removes the X.0+ notation and replaces it with X.x notation
@m2-assistant
Copy link

m2-assistant bot commented Nov 29, 2019

Hi @mautz-et-tong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@davidverholen
Copy link
Member

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, here is your new Magento instance.
Admin access: https://pr-25838.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-6364 has been created to process this Pull Request
✳️ @davidverholen, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@davidverholen davidverholen added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 29, 2019
@engcom-Alfa engcom-Alfa self-assigned this Nov 29, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Note: @mautz-et-tong You can also create a PR on the magento/merchdocs repository to correct the X.0+ notation for the user documentation.

Thanks!

@engcom-Foxtrot engcom-Foxtrot self-assigned this Dec 2, 2019
@engcom-Foxtrot engcom-Foxtrot added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 2, 2019
@engcom-Foxtrot
Copy link
Contributor

@mautz-et-tong, thank you for the contribution. Please, cover changes by MFTF tests.

@mautz-et-tong
Copy link
Contributor Author

@engcom-Foxtrot tell me please: what exactly should I cover with MFTF? Have you seen the PR? I switched comments and labels and stuff like that. Are there test failing now, because the comments and labels were checked? Or should I add tests to tests if the labels are now exactly in the new notation? I really don't know what do do here...

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:09
@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 16, 2019
@engcom-Alfa
Copy link
Contributor

@mautz-et-tong Could you resolve merge conflicts?
Thanks!

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-6364 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 29, 2019

Hi @mautz-et-tong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants