Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue 25896: Cannot create folder using only letters #25904

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Consistency between message and behavior when create Non-latin letter folder => Change message to:
    Please rename the folder using only Latin letters, numbers, underscores and dashes.

This PR was covered by Unit Test.

Fixed Issues (if relevant)

  1. Cannot create folder using only letters #25896: Cannot create folder using only letters

Manual testing scenarios (*)

  1. On CMS edit page open media gallery
  2. Click "Create Folder"
  3. Type in "папка"
  4. Click "OK"

Expected result

  1. Consistency between message and behavior. => Change message to:
    Please rename the folder using only Latin letters, numbers, underscores and dashes.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-25904.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like extending the media browser component lib/web/mage/adminhtml/browser.js (newFolder function) with frontend validation is complicated. So let's stick to at least proper backend validation messages for now.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:00
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Dec 9, 2019
@edenduong
Copy link
Contributor Author

@dmytro-ch: I have updated the csv file. You can check it again. Thank you !

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6443 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 12, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants