Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Duplicate Records when sorting column in Content->Themes Grid issue25925 #25926

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Dupplicate Records when sorting column in Content->Themes Grid #25925: Duplicate Records when sorting column in Content->Themes Grid

Fixed Issues (if relevant)

  1. Dupplicate Records when sorting column in Content->Themes Grid #25925: Duplicate Records when sorting column in Content->Themes Grid

Manual testing scenarios (*)

  1. Go to backend
  2. Content->Themes
  3. Click Theme Title to sort
  4. Click Theme title to sort again
    => Doesn't duplicate records

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 6, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @edenduong
Unfortunately, we only accept Pull Requests to the following branches: 2.2-develop, 2.3-develop.
Please create a new Pull Request and use one of those as a target.

Thank you.

@m2-assistant
Copy link

m2-assistant bot commented Dec 6, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@edenduong edenduong reopened this Dec 6, 2019
@dmytro-ch dmytro-ch self-assigned this Dec 6, 2019
@dmytro-ch
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request.
Unfortunately, I can only deploy instances for 2.2-develop and 2.3-develop base branches

@dmytro-ch dmytro-ch added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Dec 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6425 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Dec 9, 2019
@engcom-Golf engcom-Golf added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Dec 9, 2019
@engcom-Golf engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Dec 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dupplicate Records when sorting column in Content->Themes Grid
8 participants