26064 issuefix #26066

divyajyothi5321 · 2019-12-16T15:22:35Z

Description (*)

Fixed Issues (if relevant)

Incorrect Error Message While Sharing Wish list more than Specified Email Address Value in Admin Configuration #26064: Incorrect Error Message While Sharing Wish list more than Specified Email Address Value in Admin Configuration

Manual testing scenarios (*)

Go to frontend and login as Cutomer.
Add any product to wish list.
Go to My account dashboard -> My Wish list
Enter around 20 to 30 email addresses and share wish list.
The issue is fixed with this code. Please refer the screenshot.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-12-16T15:22:38Z

Hi @divyajyothi5321. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

divyajyothi5321 · 2019-12-17T09:38:18Z

@engcom-Bravo the static check is always failing at the part of the code which we haven't touched, please let us know what action we need to take here.

krzksz

Hello @divyajyothi5321, thank you for your contribution! Can you please adjust the rest of the code so that static tests pass?

divyajyothi5321 · 2019-12-17T11:18:29Z

@krzksz I have made text change for the message and it is properly formatted. Can you Please let me know the exact place where I need to make the change to pass the static test.

krzksz

Static tests ask you to remove @package Magento\Wishlist\Controller\Index and add some meaningful description to the class.

krzksz · 2019-12-17T19:05:05Z

app/code/Magento/Wishlist/Controller/Index/Send.php

@@ -204,7 +204,7 @@ public function execute()
                $error = __('Please enter an email address.');
            } else {
                if (count($emails) > $emailsLeft) {
-                    $error = __('This wish list can be shared %1 more times.', $emailsLeft);
+                    $error = __('Maximum of %1 Emails can be Sent.', $emailsLeft);


Please adjust the wording to Maximum of %1 emails can be sent. (letter casing).

This still should be adjusted.

divyajyothi5321 · 2019-12-18T09:24:52Z

@krzksz even after changing the file as per your suggestion, the static test failed once again. could you please review and let us know the fix.

krzksz

There is one error displayed:

PHPStan detected violation(s):
 ------ -------------------------------------------------------------------- 
  Line   app/code/Magento/Wishlist/Controller/Index/Send.php                 
 ------ -------------------------------------------------------------------- 
  325    Method Magento\Wishlist\Controller\Index\Send::getRssLink() should  
         return mixed but return statement is missing.                       
 ------ -------------------------------------------------------------------- 

 [ERROR] Found 1 error

FYI: you can check the error yourself by clicking the Details link next to the certain test.

krzksz · 2019-12-23T07:38:57Z

app/code/Magento/Wishlist/Controller/Index/Send.php

@@ -204,7 +204,7 @@ public function execute()
                $error = __('Please enter an email address.');
            } else {
                if (count($emails) > $emailsLeft) {
-                    $error = __('This wish list can be shared %1 more times.', $emailsLeft);
+                    $error = __('Maximum of %1 Emails can be Sent.', $emailsLeft);


This still should be adjusted.

krzksz · 2019-12-23T10:10:23Z

Hey @divyajyothi5321, thank you for the contribution!
According to our Definition of Done, all code changes should be covered by tests.

magento-engcom-team · 2019-12-23T10:10:40Z

Hi @krzksz, thank you for the review.
ENGCOM-6518 has been created to process this Pull Request

divyajyothi5321 · 2019-12-24T11:06:49Z

@krzksz how to cover auto testing kindly can you please let me know

engcom-Golf · 2020-01-02T09:37:06Z

HI @divyajyothi5321 @krzksz all changes covered by unit test, could you please review ?

magento-engcom-team · 2020-01-02T10:20:40Z

Hi @krzksz, thank you for the review.
ENGCOM-6518 has been created to process this Pull Request

engcom-Delta · 2020-01-02T11:03:04Z

✔️ QA passed

engcom-Golf · 2020-01-02T12:40:37Z

Functional test fails on 2.4-develop branch, fix in -> #26225

m2-assistant · 2020-01-03T16:22:46Z

Hi @divyajyothi5321, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

26064 issuefix

a882be9

divyajyothi5321 added Area: Frontend partners-contribution Pull Request is created by Magento Partner Component: Wishlist Partner: i95Dev labels Dec 16, 2019

divyajyothi5321 requested a review from kanthy-i95dev December 16, 2019 15:22

divyajyothi5321 requested a review from paliarush as a code owner December 16, 2019 15:22

krzksz suggested changes Dec 17, 2019

View reviewed changes

ghost assigned krzksz Dec 17, 2019

ghost added the Progress: needs update label Dec 17, 2019

krzksz suggested changes Dec 17, 2019

View reviewed changes

divyajyothi5321 added 2 commits December 18, 2019 12:37

Added requested Changes

e830f2e

Changes Added

0d22017

divyajyothi5321 requested a review from krzksz December 18, 2019 09:21

krzksz suggested changes Dec 18, 2019

View reviewed changes

Update Send.php

8251bc9

divyajyothi5321 requested a review from krzksz December 21, 2019 05:14

krzksz suggested changes Dec 23, 2019

View reviewed changes

added requested changes

0802b48

divyajyothi5321 requested a review from krzksz December 23, 2019 10:04

krzksz approved these changes Dec 23, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Dec 23, 2019

krzksz added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Dec 23, 2019

magento-engcom-team added the Release Line: 2.4 label Dec 23, 2019

engcom-Alfa self-assigned this Dec 23, 2019

ghost added Progress: needs update and removed Progress: ready for testing labels Dec 23, 2019

cover changes with unit test

add2bbb

engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 2, 2020

engcom-Golf self-assigned this Jan 2, 2020

divyajyothi5321 requested a review from krzksz January 2, 2020 10:12

krzksz approved these changes Jan 2, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jan 2, 2020

engcom-Delta self-assigned this Jan 2, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jan 2, 2020

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Jan 2, 2020

magento-engcom-team pushed a commit that referenced this pull request Jan 3, 2020

ENGCOM-6518: 26064 issuefix #26066

4e6f316

magento-engcom-team merged commit add2bbb into magento:2.4-develop Jan 3, 2020

eduard13 mentioned this pull request Mar 19, 2020

Incorrect Error Message While Sharing Wish list more than Specified Email Address Value in Admin Configuration #26064

Closed

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

26064 issuefix #26066

26064 issuefix #26066

divyajyothi5321 commented Dec 16, 2019

m2-assistant bot commented Dec 16, 2019

divyajyothi5321 commented Dec 17, 2019

krzksz left a comment

divyajyothi5321 commented Dec 17, 2019

krzksz left a comment

krzksz Dec 17, 2019

krzksz Dec 23, 2019

divyajyothi5321 commented Dec 18, 2019

krzksz left a comment

krzksz Dec 23, 2019

krzksz commented Dec 23, 2019

magento-engcom-team commented Dec 23, 2019

divyajyothi5321 commented Dec 24, 2019

engcom-Golf commented Jan 2, 2020

magento-engcom-team commented Jan 2, 2020

engcom-Delta commented Jan 2, 2020

engcom-Golf commented Jan 2, 2020

m2-assistant bot commented Jan 3, 2020

26064 issuefix #26066

26064 issuefix #26066

Conversation

divyajyothi5321 commented Dec 16, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Dec 16, 2019

divyajyothi5321 commented Dec 17, 2019

krzksz left a comment

Choose a reason for hiding this comment

divyajyothi5321 commented Dec 17, 2019

krzksz left a comment

Choose a reason for hiding this comment

krzksz Dec 17, 2019

Choose a reason for hiding this comment

krzksz Dec 23, 2019

Choose a reason for hiding this comment

divyajyothi5321 commented Dec 18, 2019

krzksz left a comment

Choose a reason for hiding this comment

krzksz Dec 23, 2019

Choose a reason for hiding this comment

krzksz commented Dec 23, 2019

magento-engcom-team commented Dec 23, 2019

divyajyothi5321 commented Dec 24, 2019

engcom-Golf commented Jan 2, 2020

magento-engcom-team commented Jan 2, 2020

engcom-Delta commented Jan 2, 2020

engcom-Golf commented Jan 2, 2020

m2-assistant bot commented Jan 3, 2020