Textarea patch 1

[textarea]

Description (*)

On modal setTitle() call, subTitle tag get erased and not appended any more, caused by:
modalSubTitle: '[data-role="subTitle"]'

Fixed Issues (if relevant)

1. Modal Popup and Custom subTitle erased #26141: Modal Popup and Custom subTitle erased

Manual testing scenarios (*)

1. Create a popup or custom modal with a title and subtitle.
2. Change title with setTitle() method

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @textarea. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[krzksz]

I think we should rather change the selector in JavaScript file to [data-role="subtitle"] as I wasn't able to find camel case data-role attribute value anywhere else in Magento.

[textarea]

Hi @krzksz, as you prefer, but there are different camel case data-role attributes, for example:
modalCloseBtn: '[data-role="closeBtn"]' in the same modal.js file.

[krzksz]

That's true I don't know why I didn't find it when searching through the files.

[magento-engcom-team]

Hi @krzksz, thank you for the review.
ENGCOM-6517 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[krzksz]

Hi @textarea, great contribution!
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by auto test.

[engcom-Golf]

I will take care of test coverage

[textarea]

Thanks @Nazar65 !

[engcom-Alfa]

✔️ QA Passed

[engcom-Golf]

failed Functional Tests B2B Not related to the changes in this PR

[magento-engcom-team]

Hi @krzksz, thank you for the review.
ENGCOM-6517 has been created to process this Pull Request

[slavvka]

@textarea Please fix failing Unit test

[Nazar65]

I will fix them

[Nazar65]

@slavvka done ✔️

[m2-assistant]

Hi @textarea, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.