Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for footer newsletter input field length in IE/Edge #26182

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Fix for footer newsletter input field length in IE/Edge #26182

merged 2 commits into from
Jan 3, 2020

Conversation

divyajyothi5321
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Footer Newsletter input field width is not identical in Internet Explorer/EDGE browser compared with chrome #26176: Footer Newsletter input field width is not identical in Internet Explorer/EDGE browser compared with chrome

Manual testing scenarios (*)

  1. Go to Front-end footer section
  2. With this fix the newsletter input field width is identical in Internet Explorer/Edge Browser as shown below
    search-expected

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 26, 2019

Hi @divyajyothi5321. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: i95Dev partners-contribution Pull Request is created by Magento Partner labels Dec 26, 2019
@rogyar rogyar changed the title Added fix for - 26176 Fix for footer newsletter input field length in IE/Edge Dec 28, 2019
@rogyar rogyar self-assigned this Dec 28, 2019
@rogyar
Copy link
Contributor

rogyar commented Dec 28, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-26182.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6525 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Dec 30, 2019
@engcom-Delta
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Delta, here is your new Magento instance.
Admin access: https://pr-26182.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf engcom-Golf self-assigned this Dec 30, 2019
@VladimirZaets VladimirZaets mentioned this pull request Jan 3, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 3, 2020
@VladimirZaets
ENGCOM-6525: Fix for footer newsletter input field length in IE/Edge #…
c966d91 
…26182
@magento-engcom-team magento-engcom-team merged commit adc7908 into magento:2.4-develop Jan 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 3, 2020

Hi @divyajyothi5321, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@kanthy-i95dev kanthy-i95dev Awaiting requested review from kanthy-i95dev

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Golf engcom-Golf

Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyajyothi5321 @rogyar @magento-engcom-team @engcom-Delta @engcom-Golf