-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Fix for - 26181 #26183
Added Fix for - 26181 #26183
Conversation
Hi @divyajyothi5321. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @rogyar. Thank you for your request. I'm working on Magento instance for you |
Hi @rogyar, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @divyajyothi5321. Thank you for your collaboration.
At some resolutions, they are still not aligned (check the wishlist and compare icons).
Also, I'm not sure that an additional color (orange) should be used in this particular case. The alignment fix is required, no doubts here. But bringing additional colors to the theme might be a topic for additional debates.
@rogyar Can we add custom breakpoints in theme |
Hi @divyajyothi5321. The tests are slightly broken. We are waiting for PR with the fixes for tests to be merged soon. |
@rogyar thank you for your suggestion, I didn't add any custom media queries adjusted with existing media queries and now all checks are passed please review my latest changes and let me know for any modifications. |
@magento give me test instance |
Hi @rogyar. Thank you for your request. I'm working on Magento instance for you |
Hi @rogyar, here is your new Magento instance. |
Hi @divyajyothi5321. Now it's much better. Thank you |
Hi @rogyar, thank you for the review. |
✔️ QA passed |
Hi @divyajyothi5321, thank you for your contribution! |
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)