Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled the sorting option in status column on cache grid #26215

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Dec 31, 2019

Description (*)

This PR to disable the sorting option in status column at cache grid.

Fixed Issues (if relevant)

  1. Sorting issue for status column for Cache Management #26208

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Actually rest of the column has no sorting options & no pagination in cache grid, so My thought is sorting option of status column is not required. please share you feedback I am happy to update this PR itself.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 31, 2019

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Dec 31, 2019
@lbajsarowicz
Copy link
Contributor

Why?

@srsathish92
Copy link
Contributor Author

Why?

@lbajsarowicz Thought came from #26208. can you please give your feedback.

@lbajsarowicz
Copy link
Contributor

Is there any option to make it work properly?

@srsathish92
Copy link
Contributor Author

@lbajsarowicz No, Because the options (with html loaded from this Magento\Backend\Block\Cache\Grid\Column\Statuses) including Invalidated status. can you please suggest if any options?

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6531 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Jan 3, 2020
@engcom-Golf engcom-Golf added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 3, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants