-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extraneous whitespace - #26275 #26285
Conversation
Hi @DanielRuf. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Which violations are meant here?
|
@DanielRuf Thanks for your contribution. You changed a file and when you do it Magento will run static tests against this file, so even if the problem is older than your changes you must fix all it to get pass in the tests. Specifically in your case changes aren't hard... You must do 2 types of refactoring: First:You must change all
Second:The easiest one, you just have to guarantee that PHP code lines aren't too big, it must be equal or lesser than 120 characters per line. |
Well it says "2 violations" which is not very clear. Also warnings should be actual errors then. |
Indeed, maybe a maintainer can be more helpful to this matter. |
Currently trying to fix the outstanding PHPCS violations. |
Good luck and have fun :) |
Hm, I see no real step for step description for migrating the |
Extract them to shorten lines and resolve codestyle warnings
Not sure about the helpers as I have mostly only worked on the frontend part of Magento 2. Would be great to get some help with this. |
I will check the failing tests later. |
Hi @nuzil, thank you for the review.
|
✔️ QA passed |
@DanielRuf i will take care of satic test |
I already did. No need to. |
Hi @DanielRuf, thank you for your contribution! |
Description (*)
This PR removes the extraneous spaces from the labels.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Without this PR:
With the fixes in the PR:
Questions or comments
Contribution checklist (*)