Issue-25968 - Added additional checking for returning needed variable…

[AndreyChorniy]

Description (*)

This PR add fix for returned type for getPrice() method. Also added unit tests coverage for method getPrice.

Fixed Issues (if relevant)

1. getPrice() returns a string when setting custom price in admin order #25968: getPrice() returns a string when setting custom price in admin order

Manual testing scenarios (*)

We have not easy steps to manual test these changes.
I can recommend use sandboxes to get test it more easily

[m2-assistant]

Hi @AndreyChorniy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[eduard13]

Hi @AndreyChorniy, thanks for your contribution, could you please check the comments that I left?

[rogyar]

Hi @AndreyChorniy. Please, take a look at the failing tests as well. Thank you

[lbajsarowicz]

Covering all the use cases in single Test method is considered to be a bad practice.

You should introduce another Test method - for example testGetPriceReturnsNull()
`

[eduard13]

Thank you for your fixes, could you please check the other minor recommendations?

[AndreyChorniy]

Hi @AndreyChorniy. Please, take a look at the failing tests as well. Thank you

Hello @rogyar, I have fixed failed tests.

[eduard13]

Looks good for me.
Thanks.

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-6627 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @AndreyChorniy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.