Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Replace invalid ActionGroup for AdminLogin #26329

Merged
merged 7 commits into from
Feb 28, 2020
Merged

MFTF: Replace invalid ActionGroup for AdminLogin #26329

merged 7 commits into from
Feb 28, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jan 9, 2020 •
edited
Loading

Description (*)

The ActionGroup for logging in as admin was declared in module-cms-staging that is completely ridiculous. I moved that as a legacy one to backend module, as we already have 3 action groups for such behavior 🤦‍♂️ After merging all related Pull Requests, that Action Group can be removed.

Fixed Issues (if relevant)

  1. https://github.com/magento/partners-magento2ee/pull/113
  2. [ MFTF ] Mess in ActionGroups: invalid names, multiple nodes. #26331

Questions or comments

Had to extract the changes per-module. The previous try failed, because of conflicts.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Jan 9, 2020
@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 9, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 9, 2020
@lbajsarowicz lbajsarowicz changed the title MFTF: Extract Action Groups to separate files - magento/module-cms-staging MFTF: Replace invalid ActionGroup for AdminLogin Jan 9, 2020
@dmytro-ch
Copy link
Contributor

Hi @lbajsarowicz, unfortunately, I could not find the original action group in 2.4-develop branch.
https://github.com/magento/magento2/tree/2.4-develop/app/code/Magento/Cms/Test/Mftf/ActionGroup
Have you already removed this action in the scope of another PR?

@lbajsarowicz
Copy link
Contributor Author

lbajsarowicz commented Jan 10, 2020 •
edited
Loading

CMS Staging module
Take a look into linked issue https://github.com/magento/partners-magento2ee/pull/113

-- Especially: https://github.com/magento/partners-magento2ee/pull/113/files#diff-1dc91bcc26d07540dece9d2a9931e2feL108

@dmytro-ch
Copy link
Contributor

These action groups still have different names: LoginAsAnyUserActionGroup and LoginAsAnyUser.
Shouldn't we name it LoginAsAnyUser instead of LoginAsAnyUserActionGroup in this case?
Sorry for asking many questions, I just want to make sure I got the idea correctly. :)

@lbajsarowicz
Copy link
Contributor Author

You are right. Thank you!

@dmytro-ch dmytro-ch added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Jan 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6594 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 13, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Golf engcom-Golf self-assigned this Jan 13, 2020
lenaorobei
lenaorobei requested changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you mark it as deprecated instead of removing it?

@ghost ghost assigned lenaorobei Jan 23, 2020
@lenaorobei lenaorobei added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Feb 26, 2020
@lbajsarowicz
Copy link
Contributor Author

image

✔️ Lucky PR

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6594 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Golf
Copy link
Contributor

Hi @lbajsarowicz could you please resolve conflicts ?

@lbajsarowicz
Copy link
Contributor Author

@magento run Functional Tests CE
Flaky test

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 28, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 28, 2020
@slavvka
ENGCOM-6594: MFTF: Replace invalid ActionGroup for AdminLogin #26329
da6d6cf
@magento-engcom-team magento-engcom-team merged commit 984ff4c into magento:2.4-develop Feb 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@dmytro-ch dmytro-ch

@lenaorobei lenaorobei

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: complex Component: AdminAnalytics Component: AdminNotification Component: Analytics Component: Backend Component: Backup Component: Braintree Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lbajsarowicz @dmytro-ch @magento-engcom-team @engcom-Alfa @okolesnyk @lenaorobei @engcom-Golf