Fixed #26345 Reorder in Admin panel leads to report page in case of changed product custom option max characters #26348

cedmudit · 2020-01-10T22:01:16Z

Fixed #26345 Reorder in Admin panel leads to report page in case of changed product custom option max characters

Preconditions (*)

Magento ver. 2.3.2-p2.

Steps to reproduce (*)

Configure a product with text (area) custom option, that has "Max Characters" value = 15.
Place an order with the configured product.
2.1. The text custom option value should be at least 11 symbols length.
Change the value of the product text custom option "Max Characters" to 10 (or less).
Go to the placed order in Admin panel.
Click on "Reorder" button.

Expected result (*)

The Admin user see a clear error message, that explains, why the order couldn't reordered.
Probably it's enough to implement it in the same way as on frontend for registered customer:
registered customer - reorder after changing max characters - error message
Actual result (*)

The Admin user see a report page

Description (*)

Fixed Issues (if relevant)

magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Update Reorder.php so that it can handle the Localized Exception and added try catch block

m2-assistant · 2020-01-10T22:01:19Z

Hi @cedmudit. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

rogyar

Hi @cedmudit. Thank you for your contribution. Could I kindly ask you to cover your change using an automated test? I would recommend a unit test or MFTF test in this particular case.

Also, consider checking the failing static tests as well.

Thank you!

engcom-Echo · 2020-02-06T08:55:33Z

I will take care of test coverage.

… 2.3-developPR26345

rogyar · 2020-02-09T16:02:50Z

@magento run functional tests

rogyar

It looks like the reorder functionality for MSI has been affected by this change. Please, take a look at the failing functional tests.

engcom-Echo · 2020-02-19T07:54:19Z

@magento run all tests

… 2.3-developPR26345

rogyar · 2020-02-22T13:45:40Z

Looks like they were just fluky tests

rogyar · 2020-02-22T13:49:32Z

app/code/Magento/Sales/Controller/Adminhtml/Order/Create/Reorder.php

+                $this->_getSession()->setUseOldShippingMethod(true);
+                $this->_getOrderCreateModel()->initFromOrder($order);
+                $resultRedirect->setPath('sales/*');
+            } catch (\Magento\Framework\Exception\LocalizedException $e) {


Hi @cedmudit. I've noticed that we don't log the exception. It's not that critical in case of LocalizedException since we show the message using the messageManager. However, it's still recommended to log the exception.

In the case of catching \Exception it's very important to have the details in the error log. Otherwise, we just catch the exception and hide important error details.

Please, add error logging for both cases. Thank you!

Hi, @rogyar. I will add an error logging.

Pull Request state was updated. Re-review required.

rogyar · 2020-03-13T11:58:00Z

The failing tests are not related to the current PR since we have the same tests failing for other PRs

magento-engcom-team · 2020-03-13T11:59:45Z

Hi @rogyar, thank you for the review.
ENGCOM-7090 has been created to process this Pull Request

engcom-Delta · 2020-03-16T12:07:49Z

✔️ QA passed

engcom-Echo · 2020-03-16T13:27:34Z

Failed functional tests not related to the changes in this PR

… in case of changed product custom option max characters #26348

m2-assistant · 2020-03-17T05:19:56Z

Hi @cedmudit, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Update Reorder.php

16079d9

Update Reorder.php so that it can handle the Localized Exception and added try catch block

cedmudit requested a review from joni-jones as a code owner January 10, 2020 22:01

magento-engcom-team added Community Insider: Cedcommerce community-insider-contribution labels Jan 10, 2020

rogyar self-assigned this Jan 11, 2020

rogyar requested changes Jan 11, 2020

View reviewed changes

ghost added the Progress: needs update label Jan 11, 2020

engcom-Echo self-assigned this Feb 6, 2020

engcom-Echo added 2 commits February 6, 2020 11:18

Merge branch '2.4-develop' of http://github.com/magento/magento2 into…

86dc12d

… 2.3-developPR26345

Cover unit test

a21b246

engcom-Echo added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 6, 2020

engcom-Echo requested a review from rogyar February 6, 2020 13:15

Add implement HttpPostActionInterface for renderer controller

43f9e2b

engcom-Echo force-pushed the 2.3-developPR26345 branch from 4157d97 to 43f9e2b Compare February 7, 2020 07:24

rogyar requested changes Feb 18, 2020

View reviewed changes

engcom-Echo added 2 commits February 20, 2020 10:20

Merge branch '2.4-develop' of http://github.com/magento/magento2 into…

7ba11b8

… 2.3-developPR26345

Changed implements class

6c5fbcb

engcom-Echo requested a review from rogyar February 20, 2020 12:08

rogyar previously requested changes Feb 22, 2020

View reviewed changes

Added an error logging

f7819a6

engcom-Echo requested a review from rogyar March 12, 2020 11:14

rogyar added the Award: bug fix label Mar 13, 2020

rogyar approved these changes Mar 13, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Mar 13, 2020

magento-engcom-team added Release Line: 2.4 Component: Sales labels Mar 13, 2020

engcom-Delta self-assigned this Mar 16, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 16, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Mar 16, 2020

ghost added Progress: accept and removed Progress: extended testing labels Mar 16, 2020

slavvka mentioned this pull request Mar 17, 2020

Reorder in Admin panel leads to report page in case of changed product custom option max characters #26345

Closed

magento-engcom-team pushed a commit that referenced this pull request Mar 17, 2020

ENGCOM-7090: Fixed #26345 Reorder in Admin panel leads to report page…

3a803bb

… in case of changed product custom option max characters #26348

magento-engcom-team merged commit 16edf9e into magento:2.4-develop Mar 17, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed #26345 Reorder in Admin panel leads to report page in case of changed product custom option max characters #26348

Fixed #26345 Reorder in Admin panel leads to report page in case of changed product custom option max characters #26348

cedmudit commented Jan 10, 2020

m2-assistant bot commented Jan 10, 2020

rogyar left a comment

engcom-Echo commented Feb 6, 2020

rogyar commented Feb 9, 2020

rogyar left a comment

engcom-Echo commented Feb 19, 2020

rogyar commented Feb 22, 2020

rogyar Feb 22, 2020

engcom-Echo Mar 12, 2020

rogyar commented Mar 13, 2020

magento-engcom-team commented Mar 13, 2020

engcom-Delta commented Mar 16, 2020

engcom-Echo commented Mar 16, 2020

m2-assistant bot commented Mar 17, 2020

Fixed #26345 Reorder in Admin panel leads to report page in case of changed product custom option max characters #26348

Fixed #26345 Reorder in Admin panel leads to report page in case of changed product custom option max characters #26348

Conversation

cedmudit commented Jan 10, 2020

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Jan 10, 2020

rogyar left a comment

Choose a reason for hiding this comment

engcom-Echo commented Feb 6, 2020

rogyar commented Feb 9, 2020

rogyar left a comment

Choose a reason for hiding this comment

engcom-Echo commented Feb 19, 2020

rogyar commented Feb 22, 2020

rogyar Feb 22, 2020

Choose a reason for hiding this comment

engcom-Echo Mar 12, 2020

Choose a reason for hiding this comment

rogyar commented Mar 13, 2020

magento-engcom-team commented Mar 13, 2020

engcom-Delta commented Mar 16, 2020

engcom-Echo commented Mar 16, 2020

m2-assistant bot commented Mar 17, 2020