Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #26332 BeforeOrderPaymentSaveObserver override payment instructions #26399

Conversation

karyna-t
Copy link
Contributor

Description (*)

Fix for the problem with BeforeOrderPaymentSaveObserver, which overrides payment instructions.

Fixed Issues (if relevant)

  1. BeforeOrderPaymentSaveObserver override payment insructions with wrong store view config #26332: BeforeOrderPaymentSaveObserver override payment insructions with wrong store view config

Manual testing scenarios (*)

Testing scenario is described in the ticket #26332 .

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 15, 2020

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 15, 2020
@rogyar rogyar self-assigned this Jan 15, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6609 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf
Copy link
Contributor

failed Functional Tests B2B Not related to the changes in this PR

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@karyna-t karyna-t deleted the 26332-fix-observer-override-payment-instructions branch August 6, 2021 19:50
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: OfflinePayments Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants