Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED: Discount fixed amount whole cart applied mutiple time when customer use Check Out with Multiple Addresses #26419

Merged

Conversation

mahesh-rajawat
Copy link
Member

Fixed Issue with CartFixed and Multishipping.

Description (*)

I have fixed issue #25834 in this PR

Fixed Issues (if relevant)

  1. Discount fixed amount whole cart applied mutiple time when customer use Check Out with Multiple Addresses #25834

Manual testing scenarios (*)

  1. Create cart rule, no condition, action: Fixed amount discount for whole cart. Discount amount $10
  2. Create account, create 2 addresses: address 1, address 2
  3. Add 2 SKUs to cart: SKU1, SKU2
  4. Check Out with Multiple Addresses
  5. SKU1 ship to address 1, SKU2 ship to address 2
  6. Order review page discount applied once. https://prnt.sc/qoju2d
  7. Placed an order discount applied in single order.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 16, 2020

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@bubasuma bubasuma self-assigned this Feb 24, 2020
@ghost ghost added the Progress: review label Feb 24, 2020
@bubasuma
Copy link
Contributor

Hi @maheshWebkul721! Our team started working on this PR in scope of MC-31800

@bubasuma
Copy link
Contributor

I am working on integration test

…customer use Check Out with Multiple Addresses

- Fix "discount fixed amount whole cart" for multi-shipping quote

- Add integration for "Discount fixed amount whole cart" with multiple shipping
@magento-engcom-team magento-engcom-team merged commit 488dfd0 into magento:2.4-develop Mar 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 5, 2020

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants