Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checked if quote object contains id before looking for quote items #26489

Merged
merged 9 commits into from
Feb 7, 2020
Merged

Checked if quote object contains id before looking for quote items #26489

merged 9 commits into from
Feb 7, 2020

Conversation

rav-redchamps
Copy link
Contributor

Description (*)

Checked if quote object contains id before looking for quote items so that it doesn’t pull all the quote items

Fixed Issues (if relevant)

  1. Viewing customer shopping cart in admin shows all products in catalog when there is no active quote #26437: Viewing customer shopping cart in admin shows all products in catalog when there is no active quote

Manual testing scenarios (*)

  1. Create a new customer account in storefront
  2. Login to admin panel and go to Customers > All Customers path
  3. Edit newly created customer and go to "Shopping Cart" tab
  4. You will observe that it lists many items but the shopping cart of the customer in the storefront is blank
  5. But if you don't see all items here, go to database table "quote" & search it for customer id, if any quote found delete that
  6. Now, refresh the customer edit page in backend & go to "Shopping Cart" tab again

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 22, 2020

Hi @rav-redchamps. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rav-redchamps
Copy link
Contributor Author

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps, here is your Magento instance.
Admin access: https://i-26489-2-4-develop.instances.magento-community.engineering/admin_4b8d
Login: 806e4ca0 Password: f2e5a4168c5b
Instance will be terminated in up to 3 hours.

@novikor novikor self-assigned this Jan 22, 2020
@novikor
Copy link
Contributor

novikor commented Jan 22, 2020

@magento run Functional Tests EE

novikor
novikor approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested.
Thank you for your contribution!

@magento-engcom-team
Copy link
Contributor

Hi @novikor, thank you for the review.
ENGCOM-6667 has been created to process this Pull Request
✳️ @novikor, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Jan 23, 2020
@novikor novikor added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 23, 2020
@novikor novikor added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 23, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jan 23, 2020
@novikor
Copy link
Contributor

novikor commented Jan 23, 2020

@magento run Functional Tests B2B

@engcom-Golf engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 30, 2020
@Nazar65 Nazar65 force-pushed the issue-26437-customer-shopping-cart-tab branch from ee88e4a to 2a0f2bd Compare January 30, 2020 15:05
@engcom-Golf
Copy link
Contributor

HI @novikor could you please review test coverage ?

@Nazar65 Nazar65 force-pushed the issue-26437-customer-shopping-cart-tab branch from 2a0f2bd to a3dc450 Compare January 30, 2020 18:23
@magento-engcom-team
Copy link
Contributor

Hi @novikor, thank you for the review.
ENGCOM-6667 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 31, 2020
@engcom-Golf
Copy link
Contributor

Failure of functional test, not related to the changes in this PR , test failing on 2.4-develop branch
DeepinScreenshot_select-area_20200131114202

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2020
@slavvka
ENGCOM-6667: Checked if quote object contains id before looking for q…
7862cbc 
…uote items #26489
@magento-engcom-team magento-engcom-team merged commit 907d0d6 into magento:2.4-develop Feb 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @rav-redchamps, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@krishprakash krishprakash mentioned this pull request Feb 10, 2020
Closed
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novikor novikor novikor approved these changes

@paliarush paliarush Awaiting requested review from paliarush

@VladimirZaets VladimirZaets Awaiting requested review from VladimirZaets

Assignees

@VladimirZaets VladimirZaets

@novikor novikor

@engcom-Alfa engcom-Alfa

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Customer Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rav-redchamps @magento-engcom-team @novikor @engcom-Delta @engcom-Golf @engcom-Alfa @VladimirZaets @engcom-Foxtrot @Nazar65