-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#26583 Tier pricing save percent showing logic updated in product detail page #26584
#26583 Tier pricing save percent showing logic updated in product detail page #26584
Conversation
Hi @srsathish92. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento-engcom-team can you please validate this PR? |
@lenaorobei @lbajsarowicz can you please validate this PR? |
@magento give me test instance |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you |
Hi @ihor-sviziev, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes looks good for me, and fix works fine:
Could you cover your changes with MFTF test like this?
- Create product with regular price=100$, special price=65$, tier price qty from 3=36%.
- Navigate to product page
- Check if on product page we can see message "Buy 3 for $64.00 each and save 2%"
Hi, @ihor-sviziev I'll take care of automated tests. |
@engcom-Charlie in general looks good, let's wait for test results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm very demanding when it comes to MFTF.
Please review the comments.
Our main recommendation is that Tests should be made mostly of reusable blocks --- Action Groups.
...agento/Catalog/Test/Mftf/Test/StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest.xml
Outdated
Show resolved
Hide resolved
...agento/Catalog/Test/Mftf/Test/StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest.xml
Outdated
Show resolved
Hide resolved
...agento/Catalog/Test/Mftf/Test/StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest.xml
Outdated
Show resolved
Hide resolved
...agento/Catalog/Test/Mftf/Test/StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest.xml
Outdated
Show resolved
Hide resolved
...agento/Catalog/Test/Mftf/Test/StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest.xml
Outdated
Show resolved
Hide resolved
@engcom-Charlie please review comments from @lbajsarowicz above and failing functional tests - looks like special price isn't applied. Please fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For failing tests you need to reindex using cron
...agento/Catalog/Test/Mftf/Test/StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest.xml
Outdated
Show resolved
Hide resolved
9f02e26
to
4680f70
Compare
...agento/Catalog/Test/Mftf/Test/StoreFrontSimpleProductWithSpecialAndTierDiscountPriceTest.xml
Show resolved
Hide resolved
Hi @ihor-sviziev, thank you for the review. |
@engcom-Charlie thank you for covering this PR with functional tests! |
…n product detail page #26584
Hi @srsathish92, thank you for your contribution! |
Description (*)
Tier pricing save percentage showing logic updated in product detail page
Fixed Issues (if relevant)
#26583
Manual testing scenarios (*)
Price - $100.00
Special price - $65.00
For 2 (Qty) - Fixed $40.00
For 3 (Qty) - Percentage 36%
Questions or comments
If any please let me know your feedback
Contribution checklist (*)