Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent undefined index error - closes #26762 #26763

Merged
merged 1 commit into from Apr 1, 2020
Merged

fix: prevent undefined index error - closes #26762 #26763

merged 1 commit into from Apr 1, 2020

Conversation

DanielRuf
Copy link
Contributor

Description (*)

This PR improves the driver option check as there was a ùndefined index`error with a ddev setup.

Related Pull Requests

Fixed Issues (if relevant)

  1. undefined index db-ssl-verify #26762

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @DanielRuf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7236 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
Screenshot from 2020-03-31 11-19-16

After:
Screenshot from 2020-03-31 11-01-54

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE

@m2-assistant
Copy link

m2-assistant bot commented Apr 1, 2020

Hi @DanielRuf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@DanielRuf DanielRuf deleted the fix/26762-check-driver-option-exists branch April 1, 2020 18:38
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants