-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoadCssAsync html format fixed for critical css #26764
LoadCssAsync html format fixed for critical css #26764
Conversation
Hi @srsathish92. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srsathish92
Your changes looks good to me.
Could you cover your changes with some tests in order to prevent appearing this issue in future?
@ihor-sviziev I have covered unit test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Changes looks really good for me, only one small adjustment still needed.
Failing integration tests looks not related to this PR
Hi @ihor-sviziev, thank you for the review. |
✔️ QA passed |
Failed functional test not related to the changes in this PR test fails in 2.4-develop with MSI modules. |
Hi @srsathish92, thank you for your contribution! |
Description (*)
LoadCssAsync html format fixed
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)