Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26917 Tax rate zip/post range check box alignment issue #26932

Conversation

srsathish92
Copy link
Contributor

Description (*)

This PR fixed the issue #26917. I added new class in template because I can't able to find any specific field set for that section. Same type of style applied in Customer Module itself which I get a reference from app/design/adminhtml/Magento/backend/Magento_Customer/web/css/source/_module.less Line No: 105 to 109.

Fixed Issues (if relevant)

  1. Tax rate Zip/Post range and check box alignment issue #26917

Manual testing scenarios (*)

  • GOTO Admin -> Store -> Taxes -> Tax Zones and Rates -> Add new -> Tax rate Zip/Post range
  • Checkbox alignment should be in same line

Questions or comments

If any please let me know the feedback

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@edenduong edenduong self-assigned this Feb 24, 2020
@edenduong
Copy link
Contributor

@magento give me test instance

@ghost ghost added the Progress: review label Feb 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, here is your new Magento instance.
Admin access: https://pr-26932.instances.magento-community.engineering/admin_4bbc
Login: 6ef873a8 Password: d50e44fd290f
Instance will be terminated in up to 3 hours.

Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the class in the field:

        $fieldset->addField(
            'zip_is_range',
            'checkbox',
            ['name' => 'zip_is_range', 'label' => __('Zip/Post is Range'), 'value' => '1']
        );

in Magento\Tax\Block\Adminhtml\Rate\Form

I think it would be better. Thank you.

@ghost ghost dismissed edenduong’s stale review February 24, 2020 09:18

Pull Request state was updated. Re-review required.

Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment. Thank you !

@srsathish92
Copy link
Contributor Author

@edenduong Thanks for the feedback, As per your comments I have updated the changes. can you please review now.

Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-6967 has been created to process this Pull Request
✳️ @edenduong, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants