-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #26917 Tax rate zip/post range check box alignment issue #26932
Fix #26917 Tax rate zip/post range check box alignment issue #26932
Conversation
Hi @srsathish92. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @edenduong. Thank you for your request. I'm working on Magento instance for you |
Hi @edenduong, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add the class in the field:
$fieldset->addField(
'zip_is_range',
'checkbox',
['name' => 'zip_is_range', 'label' => __('Zip/Post is Range'), 'value' => '1']
);
in Magento\Tax\Block\Adminhtml\Rate\Form
I think it would be better. Thank you.
Pull Request state was updated. Re-review required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment. Thank you !
@edenduong Thanks for the feedback, As per your comments I have updated the changes. can you please review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution !
Hi @edenduong, thank you for the review.
|
✔️ QA passed |
Hi @srsathish92, thank you for your contribution! |
Description (*)
This PR fixed the issue #26917. I added new class in template because I can't able to find any specific field set for that section. Same type of style applied in Customer Module itself which I get a reference from
app/design/adminhtml/Magento/backend/Magento_Customer/web/css/source/_module.less Line No: 105 to 109
.Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
If any please let me know the feedback
Contribution checklist (*)