Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#26742: graphql mutation setShippingMethodsOnCart get wrong data in available_shipping_methods. #27004

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed SetShippingMethodsOnCart graphql mutation and covered by test. Now it returns available_shipping_methods.

Related Pull Requests

Fixed Issues (if relevant)

  1. graphql mutation setShippingMethodsOnCart get wrong data in available_shipping_methods. #26742: graphql mutation setShippingMethodsOnCart get wrong data in available_shipping_methods.

Manual testing scenarios (*)

Please see #26742

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 25, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@prabhuram93
Copy link
Contributor

Hi @engcom-Charlie ! Our internal team has started working on this PR in the scope of MC-31277.

@magento-engcom-team magento-engcom-team merged commit 8e1cdcb into magento:2.4-develop Mar 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 26, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 26, 2020
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants