Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: responsiveness for images #27041

Merged
merged 4 commits into from
Feb 28, 2020
Merged

FIX: responsiveness for images #27041

merged 4 commits into from
Feb 28, 2020

Conversation

GrimLink
Copy link
Member

@GrimLink GrimLink commented Feb 26, 2020

Description (*)

Since Magento 2.3.4 (commit d0ad63c) the height auto has been removed.
this clearly was not tested as all images on on the Magento front-end break and are distorted thanks to the size.

Fixed Issues (if relevant)

Fixes: #27040

Manual testing scenarios (*)

Setup a Magento site with version 2.3.4 or higher
Create a CSS change containing the following CSS:

img {
  height: auto;
}

This will fix the issue at hand.

The change off course is fixed at the reset styles.
Where in the previous version this solution was.
Before the change from commit d0ad63c

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @GrimLink. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@mrtuvn mrtuvn requested a review from krzksz February 27, 2020 11:53
@ghost ghost assigned krzksz Feb 27, 2020
@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6999 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@GrimLink thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrimLink Please, see my review comment. Thanks!

Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, looks great!

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6999 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @GrimLink, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@GrimLink GrimLink deleted the bugfix/responsive-images branch July 10, 2020 18:59
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images no longer responsive
5 participants