Resolved issue for Customer address is duplicated after setBillingAddressOnCart GraphQL mutation

[Aniket10Nov]

Description (*)

Resolved issue for Customer address is duplicated after setBillingAddressOnCart GraphQL mutation. If the customer set billing address is the same as the shipping address then it won't save as a new address.

Related Pull Requests

#26884

Fixed Issues (if relevant)

1. Customer address is duplicated after setBillingAddressOnCart GraphQL mutation. #26884 Customer address is duplicated after setBillingAddressOnCart GraphQL mutation.

Manual testing scenarios (*)

Do all steps via GQL:

1. Authorize ( generateCustomerToken mutation)
2. Create cart (customerCart query)
3. Add product to cart (addSimpleProductsToCart mutation)
4. Set billing address (setBillingAddressOnCart mutation).

Important: save_in_address_book: true
input:{ 
   cart_id:"cart_id"   
   billing_address:{ 
      address:{ 
      ...
         save_in_address_book:true
      }
      same_as_shipping:true
   }
}

5. Set shipping method and payment method to the cart.
6. Place order (placeOrder mutation)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Aniket10Nov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Please, make sure you preserve the PSR code style and add whitespace before the argument

[rogyar]

Hi @Aniket10Nov. According to the new Definition of Done, all new changes should be covered by automated tests. Since we don't have a GraphQl query for checking customer addresses, we are not able to cover this case using an API-functional test.
But we have a possibility to perform a GraphQl request for setting the quote address and then use the repository or resource model to assert customer addresses using an integration test. Please, refer to the following test as an example.

magento2/dev/tests/integration/testsuite/Magento/AuthorizenetGraphQl/Model/Resolver/Customer/PlaceOrderWithAuthorizeNetTest.php

Line 106 in 542395b

}

[ghost]

@nrkapoor unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[engcom-Charlie]

Hi @Aniket10Nov it is M2 core issue, please see #22596.

[prabhuram93]

Hi @Aniket10Nov , @rogyar! Our internal team has started working on this in the scope of MC-31586

[m2-assistant]

Hi @Aniket10Nov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[lenaorobei]

Covered by tests internally.