Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #27117 Invalid functional Test names #27118

Merged
merged 5 commits into from
Mar 18, 2020
Merged

FIX #27117 Invalid functional Test names #27118

merged 5 commits into from
Mar 18, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Mar 1, 2020 •
edited by lenaorobei
Loading

Description (*)

Fix the Test names, rename wrong files.
As a side effect, more tests can be run than previously.

Related Pull Requests

Other Related

To be done later

Fixed Issues (if relevant)

  1. MFTF: Test names are not following Best Practices (Test suffix) #27117

Manual testing scenarios (*)

N/A

Questions or comments

This change might cause hundreds of failures as previously ignored will be run now.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 1, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

This was referenced Mar 1, 2020
Merged
Merged
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
To run them for EE + B2B + Inventory + PageBuilder

@lbajsarowicz
Copy link
Contributor Author

lbajsarowicz commented Mar 1, 2020 •
edited
Loading

Tests are not being generated as magento/inventory had tests that were previously ignored by the runner. Renaming them to correct pattern caused running them on CI. As a result - tests that were not run - are not causing the issues with stepKey references.

@rogyar rogyar self-assigned this Mar 2, 2020
@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: category of expertise labels Mar 2, 2020
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

I disconnected Inventory, as it requires more work.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
Thanks @okolesnyk for help with finding this TextTest 🤦‍♂️

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7040 has been created to process this Pull Request

@lbajsarowicz lbajsarowicz mentioned this pull request Mar 4, 2020
Closed
4 tasks
@lenaorobei lenaorobei added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Mar 5, 2020
@engcom-Alfa engcom-Alfa self-assigned this Mar 6, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Echo engcom-Echo self-assigned this Mar 6, 2020
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Resolved conflicts to PB: magento/magento2-page-builder#399

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Merged latest -develop branches to all related PRs

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Still getting false negatives.

@lenaorobei
Copy link
Contributor

@magento run all tests

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
There was missing reference to PageBuilder EE

@magento-engcom-team magento-engcom-team mentioned this pull request Mar 18, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Mar 18, 2020
@lenaorobei
ENGCOM-7040: FIX #27117 Invalid functional Test names #27118
14dfa6f
@magento-engcom-team magento-engcom-team merged commit c4d59d1 into magento:2.4-develop Mar 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 18, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: multiple Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lbajsarowicz @magento-engcom-team @engcom-Alfa @lenaorobei @rogyar @engcom-Echo