magento/magento2#14086: Guest cart API ignoring cartId in url for some methods

[engcom-Charlie]

Description (*)

Now guest cart API doesn't ignore card from URL. Covered by test.

Related Pull Requests

Fixed Issues (if relevant)

1. Guest cart API ignoring cartId in url for some methods #14086: Guest cart API ignoring cartId in url for some methods

Manual testing scenarios (*)

Please see #14086

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[aleron75]

Hello @engcom-Charlie, I also used to implement assignments within comparisons but one day someone pointed me out that it can be a bit misleading: is the = a real assignment or a bug, that is, a missing ==?

Reading the code without too much attention (it happens) it may seem a bug, someone could be tempted to correct it causing indeed a bug :)

At that point, I stopped using it and switched back to assigning the variable and doing the comparison in two different statements.

Would you consider doing that change, thus joining my group of old, wise, and defensive programmers like me? :-)

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-7075 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed
After switching to PR, the item was successfully added to cart. No %fieldName = %fieldValue errors

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.