26827 Added improvements to product attribute repository (save method) #27191

sergiy-v · 2020-03-06T14:06:23Z

Description

Added improvements to product attribute repository (save method) to convert frontend input and add swatch input type.

Fixed Issues (if relevant)

#26827

Manual testing scenarios

See #26827 issue description for details.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-03-06T14:06:25Z

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

rogyar

Hi @sergiy-v . Thank you for the great fix. Please, check my comments below for minor adjustments. Also, it looks like we need to adjust the existing integration tests. Please, check the following report for details

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27191/f9276c561e4d64b00e72a15aa03e847d/Integration/allure-report-ce/index.html#

Thank you

rogyar · 2020-03-06T16:48:05Z

.../Catalog/Test/Mftf/ActionGroup/AdminAssertProductAttributeByCodeOnProductFormActionGroup.xml

+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminAssertProductAttributeByCodeOnProductFormActionGroup">


Please, rename the action group as the following example

Suggested change

<actionGroup name="AdminAssertProductAttributeByCodeOnProductFormActionGroup">

<actionGroup name="AssertAdminProductAttributeByCodeOnProductFormActionGroup">

Renamed, thanks.

rogyar · 2020-03-06T16:50:32Z

app/code/Magento/Swatches/Model/SwatchAttributeFrontendInputConversion.php

+/**
+ * Performs the conversion of the frontend input value for attribute data
+ */
+class SwatchAttributeFrontendInputConversion


If we are talking about service, I would rename this class. So, the good practice is to start a service name with a verb. By following this practice we will get something like ConvertSwatchAttributeFrontendInput. What do you think?

You are right, I renamed the class.
The reason why I used such name - I tried to keep the same class name convent (if it's exists) for the module, like: SwatchAttributeCodes, SwatchAttributesProvider, SwatchAttributeType.

…onvert frontend input and add swatch input type for rest area

sergiy-v · 2020-03-11T06:57:33Z

Hi @sergiy-v . Thank you for the great fix. Please, check my comments below for minor adjustments. Also, it looks like we need to adjust the existing integration tests. Please, check the following report for details

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27191/f9276c561e4d64b00e72a15aa03e847d/Integration/allure-report-ce/index.html#

Thank you

@rogyar I have added the changes. The functional tests runs with errors at the current moment, but I believe it's not related to the issue/PR.

Thanks.

rogyar · 2020-03-12T11:59:15Z

app/code/Magento/Swatches/Model/ConvertSwatchAttributeFrontendInput.php

+     *
+     * @return array|null
+     */
+    public function execute(?array $data): ?array


I was thinking about the implementation for some time. Must admit that the service should not receive null as the argument since it breaks the implementation consistency. We shall try to be as more specific as possible in the types of accepting/returning in order to make the logic transparent.
From my point of view, if don't have the $data, we should not call the service. On the other hand, the service should know what's the structure of the data and then make the decision regarding the conversion process. So, let's leave it as it is.

Thank you

Thanks for your thoughts. Just to clarify, in this case this part of the logic was copied from existing logic with unit test which covers the case with NULL for some reason, that's why I decided to leave it as it was.

rogyar · 2020-03-12T12:02:45Z

@sergiy-v could you double-check the fact that the failing tests are not related to your change, please?

We have failed tests on creating an attribute with swatch for all 3 instances:

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27191/c90269c0e285fa870d2cb35408e6fc63/Functional/allure-report-ee/index.html#suites/8187718e2fd144987673ef34ee62b41b/3627bf02af52559e/

Thank you

sergiy-v · 2020-03-12T12:24:35Z

@sergiy-v could you double-check the fact that the failing tests are not related to your change, please?

We have failed tests on creating an attribute with swatch for all 3 instances:

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27191/c90269c0e285fa870d2cb35408e6fc63/Functional/allure-report-ee/index.html#suites/8187718e2fd144987673ef34ee62b41b/3627bf02af52559e/

Thank you

I see the same errors for few latest PRs which are not related to swatches, for example: #27246, #27248.
So, more likely the PR changes are not related to the errors.
Please let me know in case you see some points for double checking.

Thank you.

rogyar · 2020-03-12T12:47:16Z

You are right. Most likely they are just fluky tests.

magento-engcom-team · 2020-03-12T12:48:43Z

Hi @rogyar, thank you for the review.
ENGCOM-7082 has been created to process this Pull Request

engcom-Alfa · 2020-03-17T09:15:36Z

✔️ QA Passed

Before:

After:

…atches-improvements

engcom-Charlie · 2020-03-18T07:26:31Z

Failed functional tests not related to the changes in this PR.

… (save method) #27191

m2-assistant · 2020-03-19T08:11:46Z

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Mar 6, 2020

magento-engcom-team added Component: Catalog Component: Swatches Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 6, 2020

rogyar self-assigned this Mar 6, 2020

rogyar added Award: bug fix Award: MFTF test coverage Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Mar 6, 2020

rogyar requested changes Mar 6, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Mar 6, 2020

Added improvements to product attribute repository (save method) to c…

acfc589

…onvert frontend input and add swatch input type for rest area

sergiy-v force-pushed the 26827-product-attribute-repository-swatches-improvements branch from c9e4f39 to acfc589 Compare March 10, 2020 15:03

sergiy-v requested a review from rogyar March 11, 2020 06:57

rogyar reviewed Mar 12, 2020

View reviewed changes

rogyar approved these changes Mar 12, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Mar 12, 2020

engcom-Alfa self-assigned this Mar 12, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 12, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Mar 17, 2020

engcom-Charlie self-assigned this Mar 17, 2020

Merge branch '2.4-develop' into 26827-product-attribute-repository-sw…

fcf734f

…atches-improvements

ghost added Progress: accept and removed Progress: extended testing labels Mar 18, 2020

rogyar added the Award: advanced label Mar 18, 2020

rogyar mentioned this pull request Mar 18, 2020

Execute filtering only when a collection is passed to the data source… #25383

Open

4 tasks

magento-engcom-team mentioned this pull request Mar 19, 2020

500 when creating new product after adding attribute via API and assigning to attribute set via UI #26827

Closed

magento-engcom-team pushed a commit that referenced this pull request Mar 19, 2020

ENGCOM-7082: 26827 Added improvements to product attribute repository…

9b5e747

… (save method) #27191

magento-engcom-team merged commit 76e986c into magento:2.4-develop Mar 19, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

26827 Added improvements to product attribute repository (save method) #27191

26827 Added improvements to product attribute repository (save method) #27191

sergiy-v commented Mar 6, 2020

m2-assistant bot commented Mar 6, 2020

rogyar left a comment

rogyar Mar 6, 2020

sergiy-v Mar 11, 2020

rogyar Mar 6, 2020

sergiy-v Mar 11, 2020

sergiy-v commented Mar 11, 2020

rogyar Mar 12, 2020

sergiy-v Mar 12, 2020

rogyar commented Mar 12, 2020 •

edited

Loading

sergiy-v commented Mar 12, 2020

rogyar commented Mar 12, 2020

magento-engcom-team commented Mar 12, 2020

engcom-Alfa commented Mar 17, 2020 •

edited

Loading

engcom-Charlie commented Mar 18, 2020

m2-assistant bot commented Mar 19, 2020

	<actionGroup name="AdminAssertProductAttributeByCodeOnProductFormActionGroup">
	<actionGroup name="AssertAdminProductAttributeByCodeOnProductFormActionGroup">

26827 Added improvements to product attribute repository (save method) #27191

26827 Added improvements to product attribute repository (save method) #27191

Conversation

sergiy-v commented Mar 6, 2020

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

m2-assistant bot commented Mar 6, 2020

rogyar left a comment

Choose a reason for hiding this comment

rogyar Mar 6, 2020

Choose a reason for hiding this comment

sergiy-v Mar 11, 2020

Choose a reason for hiding this comment

rogyar Mar 6, 2020

Choose a reason for hiding this comment

sergiy-v Mar 11, 2020

Choose a reason for hiding this comment

sergiy-v commented Mar 11, 2020

rogyar Mar 12, 2020

Choose a reason for hiding this comment

sergiy-v Mar 12, 2020

Choose a reason for hiding this comment

rogyar commented Mar 12, 2020 • edited Loading

sergiy-v commented Mar 12, 2020

rogyar commented Mar 12, 2020

magento-engcom-team commented Mar 12, 2020

engcom-Alfa commented Mar 17, 2020 • edited Loading

engcom-Charlie commented Mar 18, 2020

m2-assistant bot commented Mar 19, 2020

rogyar commented Mar 12, 2020 •

edited

Loading

engcom-Alfa commented Mar 17, 2020 •

edited

Loading