Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#26749: Saving CMS Page Title from REST web API makes content empty #27237

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie commented Mar 11, 2020

Description (*)

Saving CMS Page Title from REST web API doesn't make content empty. Covered by test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Saving CMS Page Title from REST web API makes content empty #24704: Saving CMS Page Title from REST web API makes content empty

Manual testing scenarios (*)

Please see #24704

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7102 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Mar 15, 2020
@engcom-Bravo engcom-Bravo self-assigned this Mar 16, 2020
@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Mar 16, 2020

✔️ QA Passed

The Page Content is not affected by the query

{
  "page": {
    "title": "My Title",
    "active": true
  }
}

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@magento-engcom-team magento-engcom-team merged commit ca2fa02 into magento:2.4-develop Mar 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants