Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20472 added product list price modifier #27261

Conversation

sergiy-v
Copy link
Contributor

Description

Added product list price modifier to modify price attributes data to price format.

Fixed Issues

  1. Special Price shown without currency symbol in magento backoffice #20472
  2. Magento backend catalog "Cost" without currency symbol #20906
  3. Magento backend catalog "MSRP" without currency symbol #21910

Manual testing scenarios

See #20472, #20906, #21910 issues description for details.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sergiy-v
Copy link
Contributor Author

@dmytro-ch PR is ready to review, the functional tests errors are not related to the changes.
Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7104 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

The currency symbol for Special price, Cost and MAP is displayed in Catalog - Products

See the screenshot made BEFORE switching to the PR
spec_cost_map_no currency symbol_Before PR

and AFTER switching to the PR
spec_cost_map_no currency symbol_After PR

@engcom-Golf
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@m2-assistant
Copy link

m2-assistant bot commented Mar 17, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dmytro-ch
Copy link
Contributor

Added "special achievement" award due to the multiple issues fixed in the scope of one PR.
@sergiy-v thank you for your efforts and the quality job done!

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants