Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27370 Internet explorer issue:Default billing/shipping address not showing #27383

Conversation

vasilii-b
Copy link

Description (*)

This PR applies fixes to show the customer addresses under Addresses tab on a Customer Edit page in the admin area

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Internet explorer issue:Default billing/shipping address not showing #27370: Internet explorer issue:Default billing/shipping address not showing

Manual testing scenarios (*)

Please see the original issue.

The result should look like in other browsers.

IE 11 result
Result - IE11

Google Chrome result
Result - Chrome

Questions or comments

Should I provide an MFTF test for this case?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 21, 2020

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Customer Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 21, 2020
@edenduong edenduong self-assigned this Mar 22, 2020
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vasilii-b: Thank you for your contribution. I believe this PR is covered by the MFTF test in AdminAssertCustomerDefaultBillingAddress Action Group. But because the environment of MFTF now is not in IE so it can not find the problem.

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7175 has been created to process this Pull Request
✳️ @edenduong, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@edenduong edenduong added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 22, 2020
@vasilii-b
Copy link
Author

Hi @edenduong,
Could you please manage the labels for this PR? It seems the label Progress: pending review is not necessary anymore since you reviewed the changes. Should not it be Progress: ready for testing?

@engcom-Alfa
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your Magento instance.
Admin access: https://i-27383-2-4-develop.instances.magento-community.engineering/admin_2537
Login: 485538bc Password: 13e4fb9c0e6c
Instance will be terminated in up to 3 hours.

@engcom-Alfa
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your new Magento instance.
Admin access: https://pr-27383.instances.magento-community.engineering/admin_43cf
Login: 9357706a Password: 2d1f3748b23e
Instance will be terminated in up to 3 hours.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
screen1

After:
screen2

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

magento-engcom-team pushed a commit that referenced this pull request Mar 27, 2020
@magento-engcom-team magento-engcom-team merged commit a23c6fb into magento:2.4-develop Mar 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 27, 2020

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@vasilii-b vasilii-b deleted the 2730-ie-admin-customer-edit-page-addresses-tab-addresses-not-shown branch March 27, 2020 07:50
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants