Fixed the wrong behavior for a prompt modal when a user clicks on the modal overlay

[serhiyzhovnir]

Description (*)

The prompt modal performs the confirm action when a user clicks on the modal overlay.
This PR fixes this issue and adds the false argument for closeModal() method when a user clicks on the modal overlay.

Related Pull Requests

The issue starts reproducing after the changes from this 6167b0c commit.

Fixed Issues (if relevant)

1. Confirm Save Preview is performed if click outside of the Search Adobe Stock when File Name window is opened adobe-stock-integration#1002: Confirm Save Preview is performed if click outside of the Search Adobe Stock when File Name window is opened

Manual testing scenarios (*)

The manual testing scenarios and how to reproduce this issue is described in this issue magento/adobe-stock-integration#1002.

Also, it could be checked quickly with the following JS code via a browser console.

require(['jquery', 'Magento_Ui/js/modal/prompt'], function ($, prompt) {
    prompt({
        title: 'Prompt Title',
        content: $('.prompt-modal-content'),
        modalClass: 'prompt',
        value: 'Value by default',
        validation: true,
        promptField: '[data-role="promptField"]',
        attributesForm: {
            novalidate: 'novalidate',
            action: ''
        },
        actions: {
            always: function() {
                // do something when the modal is closed
            },
            confirm: function () {
                alert('Confirmation');
            },
            cancel: function () {
                // do something when the cancel button is clicked
            }
        }
    });

    jQuery('.prompt + .modals-overlay').click()
})

This code creates the Prompt popup and clicks on overlay.
In 2.4-develop you will see the alert with "Confirmation" that is triggered by the confirm action.

This issue is fixed in this PR and the prompt popup will be closed after clicking on the modal overlay.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[nuzil]

@magento give me test instance

[magento-engcom-team]

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-27399.instances.magento-community.engineering/admin_f275
Login: 1e782097 Password: f59789959763
Instance will be terminated in up to 3 hours.

[nuzil]

Hi @serhiyzhovnir
Please have a look at failed test, looks like it caused by your change:

[NO TESTCASEID]: Admin should be able to cancel and close 'create folder' modal window using ESC key and to add image to new folder (using enter key) for WYSIWYG content of Block

[sivaschenko]

Static test failure is not related to the changes in the pull request.

The same functional test is currently failing on other pull requests as well (i.e. #25360 Allure Report) so I assume it's not caused by the changes in this PR as well

[sivaschenko]

@serhiyzhovnir could you cover the changes by jasmine or MFTF test?

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-7195 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[nuzil]

Hi @sivaschenko
I meant this functional test:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27399/080f44f286f5263211409ffc95dc6e3f/Functional/allure-report-ce/index.html#suites/8187718e2fd144987673ef34ee62b41b/f6ed43ce96fd1909/

For me looks like related to Modal windows issue

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-7195 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

[engcom-Echo]

@magento run Functional Tests EE

[engcom-Echo]

Failed integration tests not related to the changes in this PR

[m2-assistant]

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.