Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#27503 : MFTF: Acceptance tests break the naming convention (Indexer + Backup) #27515

Merged
merged 9 commits into from
Apr 29, 2020
Merged

#27503 : MFTF: Acceptance tests break the naming convention (Indexer + Backup) #27515

merged 9 commits into from
Apr 29, 2020

Conversation

konarshankar07
Copy link
Contributor

Description (*)

This PR will fix the MFTF naming convention for Magento/Indexer and Magento/Backup module

Fixed Issues (if relevant)

  1. MFTF: Acceptance tests break the naming convention #27503: MFTF: Acceptance tests break the naming convention

Manual testing scenarios (*)

Generate tests with vendor/bin/mftf generate:test -f

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 31, 2020

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz
lbajsarowicz suggested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Just a minor changes. Please review the comments.

app/code/Magento/Backup/Test/Mftf/ActionGroup/DeleteBackupActionGroup.xml Outdated Show resolved Hide resolved
app/code/Magento/Backup/Test/Mftf/Test/AdminCreateAndDeleteBackupsTest.xml Outdated Show resolved Hide resolved
app/code/Magento/Backup/Test/Mftf/Test/AdminCreateAndDeleteBackupsTest.xml Outdated Show resolved Hide resolved
app/code/Magento/Backup/Test/Mftf/Test/AdminCreateAndDeleteBackupsTest.xml Outdated Show resolved Hide resolved
.../Magento/Indexer/Test/Mftf/ActionGroup/IndexerActionGroup/UpdateIndexerOnSaveActionGroup.xml Outdated Show resolved Hide resolved
...ento/Indexer/Test/Mftf/ActionGroup/IndexerActionGroup/UpdateIndexerByScheduleActionGroup.xml Show resolved Hide resolved
app/code/Magento/Store/Test/Mftf/Test/AdminDeleteStoreGroupTest.xml Outdated Show resolved Hide resolved
app/code/Magento/Store/Test/Mftf/Test/AdminDeleteStoreViewTest.xml Outdated Show resolved Hide resolved
app/code/Magento/Elasticsearch/Test/Mftf/Test/ProductQuickSearchUsingElasticSearchTest.xml Outdated Show resolved Hide resolved
@ghost ghost assigned lbajsarowicz Mar 31, 2020
@lbajsarowicz lbajsarowicz changed the title #27503 : MFTF: Acceptance tests break the naming convention #27503 : MFTF: Acceptance tests break the naming convention (Indexer + Backup) Mar 31, 2020
lbajsarowicz
lbajsarowicz suggested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my comments. I see huge improvement to this module, but still it's not perfect yet.
🤞

app/code/Magento/Backup/Test/Mftf/ActionGroup/AdminBackupDeleteActionGroup.xml Outdated Show resolved Hide resolved
app/code/Magento/Backup/Test/Mftf/ActionGroup/deleteBackupActionGroup.xml Outdated Show resolved Hide resolved
app/code/Magento/Elasticsearch/Test/Mftf/Test/ProductQuickSearchUsingElasticSearchTest.xml Outdated Show resolved Hide resolved
.../Indexer/Test/Mftf/ActionGroup/IndexerActionGroup/AdminIndexerSetUpdateOnSaveActionGroup.xml Outdated Show resolved Hide resolved
.../Indexer/Test/Mftf/ActionGroup/IndexerActionGroup/AdminIndexerSetUpdateOnSaveActionGroup.xml Show resolved Hide resolved
app/code/Magento/Store/Test/Mftf/Test/AdminDeleteStoreGroupTest.xml Outdated Show resolved Hide resolved
app/code/Magento/Store/Test/Mftf/Test/AdminDeleteStoreGroupTest.xml Outdated Show resolved Hide resolved
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7421 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

lbajsarowicz
lbajsarowicz approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Perfect, thank you : )

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7421 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Apr 15, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 15, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Kilo engcom-Kilo self-assigned this Apr 15, 2020
@slavvka slavvka added this to the 2.4.0 milestone Apr 27, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 29, 2020
@slavvka
ENGCOM-7421: #27503 : MFTF: Acceptance tests break the naming convent…
ce0f437 
…ion (Indexer + Backup) #27515
@magento-engcom-team magento-engcom-team merged commit b11dd5a into magento:2.4-develop Apr 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2020

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team mentioned this pull request Apr 30, 2020
Closed
47 tasks
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Backup Component: Elasticsearch Component: Indexer Component: Store Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@konarshankar07 @magento-engcom-team @engcom-Alfa @lbajsarowicz @slavvka @engcom-Kilo